2012-10-11 09:19:59

by James Hogan

[permalink] [raw]

Subject: [PATCH] openrisc: use kbuild.h instead of defining macros in asm-offset.c

---

This is modelled on commits such as the one below:

Commit fc1c3a003edb8a6778e64e10ef671a38c76c969e ("sh: use kbuild.h
instead of defining macros in asm-offsets.c") introduced in v2.6.26.

Signed-off-by: James Hogan <[email protected]>
---
Note I haven't tested compilation on openrisc. I'd appreciate if
somebody could check it doesn't break anything.

arch/openrisc/kernel/asm-offsets.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/arch/openrisc/kernel/asm-offsets.c b/arch/openrisc/kernel/asm-offsets.c
index 1a242a0..ddb7368 100644
--- a/arch/openrisc/kernel/asm-offsets.c
+++ b/arch/openrisc/kernel/asm-offsets.c
@@ -34,15 +34,11 @@
#include <linux/mm.h>
#include <linux/io.h>
#include <linux/thread_info.h>
+#include <linux/kbuild.h>
#include <asm/page.h>
#include <asm/pgtable.h>
#include <asm/processor.h>

-#define DEFINE(sym, val) \
- asm volatile("\n->" #sym " %0 " #val : : "i" (val))
-
-#define BLANK() asm volatile("\n->" : : )
-
int main(void)
{
/* offsets into the task_struct */
--
1.7.7.6

2012-10-25 13:33:09

by Jonas Bonn

[permalink] [raw]

Subject: Re: [PATCH] openrisc: use kbuild.h instead of defining macros in asm-offset.c

---

On Thu, 2012-10-11 at 10:03 +0100, James Hogan wrote:
> This is modelled on commits such as the one below:
>
> Commit fc1c3a003edb8a6778e64e10ef671a38c76c969e ("sh: use kbuild.h
> instead of defining macros in asm-offsets.c") introduced in v2.6.26.
>
> Signed-off-by: James Hogan <[email protected]>

Thanks, looks good. Will take this for 3.8.
/Jonas

> ---
> Note I haven't tested compilation on openrisc. I'd appreciate if
> somebody could check it doesn't break anything.
>
> arch/openrisc/kernel/asm-offsets.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/arch/openrisc/kernel/asm-offsets.c b/arch/openrisc/kernel/asm-offsets.c
> index 1a242a0..ddb7368 100644
> --- a/arch/openrisc/kernel/asm-offsets.c
> +++ b/arch/openrisc/kernel/asm-offsets.c
> @@ -34,15 +34,11 @@
> #include <linux/mm.h>
> #include <linux/io.h>
> #include <linux/thread_info.h>
> +#include <linux/kbuild.h>
> #include <asm/page.h>
> #include <asm/pgtable.h>
> #include <asm/processor.h>
>
> -#define DEFINE(sym, val) \
> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> -
> -#define BLANK() asm volatile("\n->" : : )
> -
> int main(void)
> {
> /* offsets into the task_struct */

---

Attachments:

signature.asc (198.00 B)
This is a digitally signed message part