Commit 6b5ab4f442e32f248b6fad29aafd1d5153f4dbd3 ("ARM: EXYNOS: Add
Exynos4 device tree enabled board file") added
select HAVE_SAMSUNG_KEYPAD if INPUT_KEYBOARD
to the MACH_EXYNOS4_DT Kconfig entry. But there's no Kconfig symbol
HAVE_SAMSUNG_KEYPAD. Since this select statement depends on
INPUT_KEYBOARD this entry should select KEYBOARD_SAMSUNG instead.
Signed-off-by: Paul Bolle <[email protected]>
---
0) Tested with "git grep" only.
1) Perhaps the fact that the symbol KEYBOARD_SAMSUNG enables a driver
called samsung-keypad caused confusion here. Anyhow, my choice for
KEYBOARD_SAMSUNG is only educated guesswork.
arch/arm/mach-exynos/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 6c2bdc3..068aeb5 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -403,7 +403,7 @@ config MACH_EXYNOS4_DT
depends on ARCH_EXYNOS4
select ARM_AMBA
select CPU_EXYNOS4210
- select HAVE_SAMSUNG_KEYPAD if INPUT_KEYBOARD
+ select KEYBOARD_SAMSUNG if INPUT_KEYBOARD
select PINCTRL
select PINCTRL_EXYNOS
select USE_OF
--
1.7.11.7
Paul Bolle wrote:
>
> Commit 6b5ab4f442e32f248b6fad29aafd1d5153f4dbd3 ("ARM: EXYNOS: Add
> Exynos4 device tree enabled board file") added
> select HAVE_SAMSUNG_KEYPAD if INPUT_KEYBOARD
>
> to the MACH_EXYNOS4_DT Kconfig entry. But there's no Kconfig symbol
> HAVE_SAMSUNG_KEYPAD. Since this select statement depends on
> INPUT_KEYBOARD this entry should select KEYBOARD_SAMSUNG instead.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> 0) Tested with "git grep" only.
>
> 1) Perhaps the fact that the symbol KEYBOARD_SAMSUNG enables a driver
> called samsung-keypad caused confusion here. Anyhow, my choice for
> KEYBOARD_SAMSUNG is only educated guesswork.
>
> arch/arm/mach-exynos/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 6c2bdc3..068aeb5 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -403,7 +403,7 @@ config MACH_EXYNOS4_DT
> depends on ARCH_EXYNOS4
> select ARM_AMBA
> select CPU_EXYNOS4210
> - select HAVE_SAMSUNG_KEYPAD if INPUT_KEYBOARD
> + select KEYBOARD_SAMSUNG if INPUT_KEYBOARD
> select PINCTRL
> select PINCTRL_EXYNOS
> select USE_OF
> --
> 1.7.11.7
Looks good to me, applied.
BTW, just to use only 8~12 digits of commit ID, "Commit 6b5ab4f4" is enough instead of full commit ID.
Thanks.
- Kukjin
On Thu, 2013-03-07 at 10:02 +0900, Kukjin Kim wrote:
> BTW, just to use only 8~12 digits of commit ID, "Commit 6b5ab4f4" is
> enough instead of full commit ID.
I used to do that but now I actually prefer to use 40 hex character
strings.
Sure, they're ugly, but so are strings of 10, or 12 hex characters. But
they're easier to use (I can just copy/paste them from the output of,
say, "git log"), I do not have to worry about uniqueness, ever (some
commits now already need at least 8 characters), and some git web
interfaces automagically linkify 40 character hex strings in commit
explanations (which is quite nice).
Paul Bolle