Hi,
-*- Early printk
help text says:
"You should normally N here, unless you want to debug such a crash.
(Depends on: EXPERT [=n])"
How to normally N here?
kind regards
thomas
On 03/13/13 10:15, Thomas Meyer wrote:
> Hi,
>
> -*- Early printk
>
> help text says:
> "You should normally N here, unless you want to debug such a crash.
> (Depends on: EXPERT [=n])"
>
> How to normally N here?
You'll have to enable CONFIG_EXPERT and then you can disable EARLY_PRINTK.
You may even have to disable CONFIG_EMBEDDED before you can enable
CONFIG_EXPERT (I did).
Too many hoops to have to jump through. :(
--
~Randy
Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
> On 03/13/13 10:15, Thomas Meyer wrote:
> > Hi,
> >
> > -*- Early printk
> >
> > help text says:
> > "You should normally N here, unless you want to debug such a crash.
> > (Depends on: EXPERT [=n])"
> >
> > How to normally N here?
>
> You'll have to enable CONFIG_EXPERT and then you can disable EARLY_PRINTK.
>
> You may even have to disable CONFIG_EMBEDDED before you can enable
> CONFIG_EXPERT (I did).
>
> Too many hoops to have to jump through. :(
>
Yes,
so why not do this? As the text to EARLY_PRINTK explains?
diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index b322f12..d6c2d89 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
config EARLY_PRINTK
bool "Early printk" if EXPERT
- default y
+ default n
---help---
Write kernel log output directly into the VGA buffer or to a
serial
port.
On 03/16/13 08:08, Thomas Meyer wrote:
> Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
>> On 03/13/13 10:15, Thomas Meyer wrote:
>>> Hi,
>>>
>>> -*- Early printk
>>>
>>> help text says:
>>> "You should normally N here, unless you want to debug such a crash.
>>> (Depends on: EXPERT [=n])"
>>>
>>> How to normally N here?
>>
>> You'll have to enable CONFIG_EXPERT and then you can disable EARLY_PRINTK.
>>
>> You may even have to disable CONFIG_EMBEDDED before you can enable
>> CONFIG_EXPERT (I did).
>>
>> Too many hoops to have to jump through. :(
>>
>
> Yes,
>
> so why not do this? As the text to EARLY_PRINTK explains?
Yes, the default should match the help text.
Acked-by: Randy Dunlap <[email protected]>
Please resend your patch with Signed-off-by: line.
Thanks.
>
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index b322f12..d6c2d89 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
>
> config EARLY_PRINTK
> bool "Early printk" if EXPERT
> - default y
> + default n
> ---help---
> Write kernel log output directly into the VGA buffer or to a
> serial
> port.
>
>
>
--
~Randy
On Sat, Mar 16, 2013 at 6:38 PM, Randy Dunlap <[email protected]> wrote:
> On 03/16/13 08:08, Thomas Meyer wrote:
>> Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
>>> On 03/13/13 10:15, Thomas Meyer wrote:
>>>> help text says:
>>>> "You should normally N here, unless you want to debug such a crash.
>>>> (Depends on: EXPERT [=n])"
>>>>
>>>> How to normally N here?
>> so why not do this? As the text to EARLY_PRINTK explains?
>
> Yes, the default should match the help text.
So just remove the "default n" line, as "n" is the default.
> Acked-by: Randy Dunlap <[email protected]>
>
> Please resend your patch with Signed-off-by: line.
>
> Thanks.
>
>>
>> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
>> index b322f12..d6c2d89 100644
>> --- a/arch/x86/Kconfig.debug
>> +++ b/arch/x86/Kconfig.debug
>> @@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
>>
>> config EARLY_PRINTK
>> bool "Early printk" if EXPERT
>> - default y
>> + default n
>> ---help---
>> Write kernel log output directly into the VGA buffer or to a
>> serial
>> port.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Am Samstag, den 16.03.2013, 10:38 -0700 schrieb Randy Dunlap:
> On 03/16/13 08:08, Thomas Meyer wrote:
> > Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
> > Yes,
> >
> > so why not do this? As the text to EARLY_PRINTK explains?
>
> Yes, the default should match the help text.
> Acked-by: Randy Dunlap <[email protected]>
>
> Please resend your patch with Signed-off-by: line.
>
> Thanks.
Align EARLY_PRINTK default value with help text value.
Signed-off-by: Thomas Meyer <[email protected]>
---
diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index b322f12..852d51c 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -32,7 +32,6 @@ config X86_VERBOSE_BOOTUP
config EARLY_PRINTK
bool "Early printk" if EXPERT
- default y
---help---
Write kernel log output directly into the VGA buffer or to a serial
port.
On 03/22/13 07:07, Thomas Meyer wrote:
> Am Samstag, den 16.03.2013, 10:38 -0700 schrieb Randy Dunlap:
>> On 03/16/13 08:08, Thomas Meyer wrote:
>>> Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
>>> Yes,
>>>
>>> so why not do this? As the text to EARLY_PRINTK explains?
>>
>> Yes, the default should match the help text.
>> Acked-by: Randy Dunlap <[email protected]>
>>
>> Please resend your patch with Signed-off-by: line.
>>
>> Thanks.
>
> Align EARLY_PRINTK default value with help text value.
>
> Signed-off-by: Thomas Meyer <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
Thanks.
tip??
> ---
>
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index b322f12..852d51c 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -32,7 +32,6 @@ config X86_VERBOSE_BOOTUP
>
> config EARLY_PRINTK
> bool "Early printk" if EXPERT
> - default y
> ---help---
> Write kernel log output directly into the VGA buffer or to a serial
> port.
>
>
> --
--
~Randy