2013-03-31 10:10:00

by Pali Rohár

[permalink] [raw]
Subject: [PATCH] RX-51: Fix probe order of SPI devices

From: Joni Lapilainen <[email protected]>

Without this patch LCD panel on Nokia RX-51 is still black

Signed-off-by: Joni Lapilainen <[email protected]>
Signed-off-by: Pali Rohár <[email protected]>
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index b09b5da..03290b9 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -91,8 +91,8 @@
/* list all spi devices here */
enum {
RX51_SPI_WL1251,
- RX51_SPI_MIPID, /* LCD panel */
RX51_SPI_TSC2005, /* Touch Controller */
+ RX51_SPI_MIPID, /* LCD panel */
};

static struct wl12xx_platform_data wl1251_pdata;
--
1.7.10.4


2013-03-31 11:25:30

by Pali Rohár

[permalink] [raw]
Subject: Re: [PATCH] RX-51: Fix probe order of SPI devices

On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote:
> On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote:
> > From: Joni Lapilainen <[email protected]>
> >
> > Without this patch LCD panel on Nokia RX-51 is still black
> >
> > Signed-off-by: Joni Lapilainen <[email protected]>
> > Signed-off-by: Pali Rohár <[email protected]>
>
> Tested-by: Sebastian Reichel <[email protected]>
>
> Please note, that this patch has actually been proposed by
> Aaro Koskinen <[email protected]> quite some time ago [0].
>
> [0]
> http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729
>
> -- Sebastian

CCing Aaro.

--
Pali Rohár
[email protected]


Attachments:
signature.asc (198.00 B)
This is a digitally signed message part.

2013-04-02 16:31:43

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH] RX-51: Fix probe order of SPI devices

* Pali Rohár <[email protected]> [130331 04:23]:
> On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote:
> > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote:
> > > From: Joni Lapilainen <[email protected]>
> > >
> > > Without this patch LCD panel on Nokia RX-51 is still black
> > >
> > > Signed-off-by: Joni Lapilainen <[email protected]>
> > > Signed-off-by: Pali Rohár <[email protected]>
> >
> > Tested-by: Sebastian Reichel <[email protected]>
> >
> > Please note, that this patch has actually been proposed by
> > Aaro Koskinen <[email protected]> quite some time ago [0].
> >
> > [0]
> > http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729
> >
> > -- Sebastian
>
> CCing Aaro.

Any ideas why this is happening?

Is the touch screen controller somehow pulling one of the SPI
lines before it's reset? I don't think there's any other connection
between the LCD and touch controller besides the SPI lines?

In any case there should be something in the description why
this is needed..

Regards,

Tony

2013-04-10 14:15:26

by Pali Rohár

[permalink] [raw]
Subject: Re: [PATCH] RX-51: Fix probe order of SPI devices

On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote:
> * Pali Rohár <[email protected]> [130331 04:23]:
> > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote:
> > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote:
> > > > From: Joni Lapilainen <[email protected]>
> > > >
> > > > Without this patch LCD panel on Nokia RX-51 is still
> > > > black
> > > >
> > > > Signed-off-by: Joni Lapilainen
> > > > <[email protected]> Signed-off-by: Pali Rohár
> > > > <[email protected]>
> > >
> > > Tested-by: Sebastian Reichel <[email protected]>
> > >
> > > Please note, that this patch has actually been proposed by
> > > Aaro Koskinen <[email protected]> quite some time ago
> > > [0].
> > >
> > > [0]
> > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/8172
> > > 9
> > >
> > > -- Sebastian
> >
> > CCing Aaro.
>
> Any ideas why this is happening?
>
> Is the touch screen controller somehow pulling one of the SPI
> lines before it's reset? I don't think there's any other
> connection between the LCD and touch controller besides the
> SPI lines?
>
> In any case there should be something in the description why
> this is needed..
>
> Regards,
>
> Tony

Hi Tony, look at this Aaro's email:
http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729

--
Pali Rohár
[email protected]


Attachments:
signature.asc (198.00 B)
This is a digitally signed message part.

2013-04-10 17:00:16

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH] RX-51: Fix probe order of SPI devices

* Pali Rohár <[email protected]> [130410 07:20]:
> On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote:
> > * Pali Rohár <[email protected]> [130331 04:23]:
> > > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote:
> > > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote:
> > > > > From: Joni Lapilainen <[email protected]>
> > > > >
> > > > > Without this patch LCD panel on Nokia RX-51 is still
> > > > > black
> > > > >
> > > > > Signed-off-by: Joni Lapilainen
> > > > > <[email protected]> Signed-off-by: Pali Rohár
> > > > > <[email protected]>
> > > >
> > > > Tested-by: Sebastian Reichel <[email protected]>
> > > >
> > > > Please note, that this patch has actually been proposed by
> > > > Aaro Koskinen <[email protected]> quite some time ago
> > > > [0].
> > > >
> > > > [0]
> > > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/8172
> > > > 9
> > > >
> > > > -- Sebastian
> > >
> > > CCing Aaro.
> >
> > Any ideas why this is happening?
> >
> > Is the touch screen controller somehow pulling one of the SPI
> > lines before it's reset? I don't think there's any other
> > connection between the LCD and touch controller besides the
> > SPI lines?
> >
> > In any case there should be something in the description why
> > this is needed..
> >
> > Regards,
> >
> > Tony
>
> Hi Tony, look at this Aaro's email:
> http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729

OK can we have that summarized in the patch description please?

Regards,

Tony

2013-04-24 12:24:09

by Pali Rohár

[permalink] [raw]
Subject: Re: [PATCH] RX-51: Fix probe order of SPI devices

On Wednesday 10 April 2013 19:00:05 Tony Lindgren wrote:
> * Pali Rohár <[email protected]> [130410 07:20]:
> > On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote:
> > > * Pali Rohár <[email protected]> [130331 04:23]:
> > > > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote:
> > > > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár
wrote:
> > > > > > From: Joni Lapilainen <[email protected]>
> > > > > >
> > > > > > Without this patch LCD panel on Nokia RX-51 is still
> > > > > > black
> > > > > >
> > > > > > Signed-off-by: Joni Lapilainen
> > > > > > <[email protected]> Signed-off-by: Pali
> > > > > > Rohár <[email protected]>
> > > > >
> > > > > Tested-by: Sebastian Reichel <[email protected]>
> > > > >
> > > > > Please note, that this patch has actually been
> > > > > proposed by Aaro Koskinen <[email protected]>
> > > > > quite some time ago [0].
> > > > >
> > > > > [0]
> > > > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/
> > > > > 8172 9
> > > > >
> > > > > -- Sebastian
> > > >
> > > > CCing Aaro.
> > >
> > > Any ideas why this is happening?
> > >
> > > Is the touch screen controller somehow pulling one of the
> > > SPI lines before it's reset? I don't think there's any
> > > other connection between the LCD and touch controller
> > > besides the SPI lines?
> > >
> > > In any case there should be something in the description
> > > why this is needed..
> > >
> > > Regards,
> > >
> > > Tony
> >
> > Hi Tony, look at this Aaro's email:
> > http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729
>
> OK can we have that summarized in the patch description
> please?
>
> Regards,
>
> Tony

Aaro, this patch is yours, can you resend it with description?

--
Pali Rohár
[email protected]


Attachments:
signature.asc (198.00 B)
This is a digitally signed message part.