2013-04-19 12:33:52

by Axel Lin

[permalink] [raw]
Subject: [PATCH] regulator: palmas: Add missing ctrl_addr setting for SMPS10

The ctrl_addr setting for SMPS10 is missed, thus palmas_smps_init() read/write
wrong register for SMPS10 in current code. Fix it.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/palmas-regulator.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 67ed5e5d..9254f94 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -99,6 +99,7 @@ static const struct regs_info palmas_regs_info[] = {
{
.name = "SMPS10",
.sname = "smps10-in",
+ .ctrl_addr = PALMAS_SMPS10_CTRL,
},
{
.name = "LDO1",
--
1.7.10.4



2013-04-21 09:05:55

by Laxman Dewangan

[permalink] [raw]
Subject: Re: [PATCH] regulator: palmas: Add missing ctrl_addr setting for SMPS10

On Friday 19 April 2013 06:03 PM, Axel Lin wrote:
> The ctrl_addr setting for SMPS10 is missed, thus palmas_smps_init() read/write
> wrong register for SMPS10 in current code. Fix it.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---

Acked-by: Laxman Dewangan<[email protected]>

2013-04-22 12:27:08

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: palmas: Add missing ctrl_addr setting for SMPS10

On Fri, Apr 19, 2013 at 08:33:45PM +0800, Axel Lin wrote:
> The ctrl_addr setting for SMPS10 is missed, thus palmas_smps_init() read/write
> wrong register for SMPS10 in current code. Fix it.

Applied, thanks.


Attachments:
(No filename) (210.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments