2013-04-19 16:28:32

by Namjae Jeon

[permalink] [raw]
Subject: [PATCH v4 0/7] f2fs: Add tracepoints support in f2fs filesystem

From: Namjae Jeon <[email protected]>

Add tracepoints in f2fs filesystem for tracing the filesystem
operations for information/debugging purpose if needed. All the
tracepoints are clubbed with respect to functionalities.

Change Log:
v4: Modified the tracepoints as per the review comments of
Jaegeuk Kim. Following tracepoints are added newly:

trace_f2fs_truncate_blocks_enter
trace_f2fs_truncate_blocks_exit
trace_f2fs_truncate_inode_blocks_enter
trace_f2fs_truncate_inode_blocks_exit
trace_f2fs_truncate_node
trace_f2fs_submit_write_page
trace_f2fs_do_submit_bio
trace_f2fs_write_checkpoint

While some of the tracepoints are modified to add new
parameters.

v3: Introduced TRACE_EVENT_CONDITION() macro for checking the
condition page->mapping inside the trace point function call as
per Steve's review comment for the patch

v2: Added DECLARE_EVENT_CLASS() macro for combining the similar
type of trace function calls which has same type of arguments.

v1: Introduced the tracepoint functions in f2fs filesystem.

Namjae Jeon (7):
f2fs: add tracepoints for sync & Inode operations
f2fs: add tracepoints for truncate operation
f2fs: add tracepoint for tracing the page i/o operations
f2fs: add tracepoints for GC threads
f2fs: add tracepoints to debug the block allocation & fallocate
f2fs: add tracepoints for write page operations
f2fs: add tracepoints to debug checkpoint request
--
1.7.9.5


2013-04-23 10:38:42

by Jaegeuk Kim

[permalink] [raw]
Subject: Re: [PATCH v4 0/7] f2fs: Add tracepoints support in f2fs filesystem

Hi, Namjae.

Still I found several inconsistent codes and flaws of information across
the whole patches.
I've finished changing them, so please review the subsequent patches.
Thanks,

2013-04-20 (토), 01:28 +0900, Namjae Jeon:
> From: Namjae Jeon <[email protected]>
>
> Add tracepoints in f2fs filesystem for tracing the filesystem
> operations for information/debugging purpose if needed. All the
> tracepoints are clubbed with respect to functionalities.
>
> Change Log:
> v4: Modified the tracepoints as per the review comments of
> Jaegeuk Kim. Following tracepoints are added newly:
>
> trace_f2fs_truncate_blocks_enter
> trace_f2fs_truncate_blocks_exit
> trace_f2fs_truncate_inode_blocks_enter
> trace_f2fs_truncate_inode_blocks_exit
> trace_f2fs_truncate_node
> trace_f2fs_submit_write_page
> trace_f2fs_do_submit_bio
> trace_f2fs_write_checkpoint
>
> While some of the tracepoints are modified to add new
> parameters.
>
> v3: Introduced TRACE_EVENT_CONDITION() macro for checking the
> condition page->mapping inside the trace point function call as
> per Steve's review comment for the patch
>
> v2: Added DECLARE_EVENT_CLASS() macro for combining the similar
> type of trace function calls which has same type of arguments.
>
> v1: Introduced the tracepoint functions in f2fs filesystem.
>
> Namjae Jeon (7):
> f2fs: add tracepoints for sync & Inode operations
> f2fs: add tracepoints for truncate operation
> f2fs: add tracepoint for tracing the page i/o operations
> f2fs: add tracepoints for GC threads
> f2fs: add tracepoints to debug the block allocation & fallocate
> f2fs: add tracepoints for write page operations
> f2fs: add tracepoints to debug checkpoint request

--
Jaegeuk Kim
Samsung


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part

2013-04-23 23:15:54

by Namjae Jeon

[permalink] [raw]
Subject: Re: [PATCH v4 0/7] f2fs: Add tracepoints support in f2fs filesystem

2013/4/23, Jaegeuk Kim <[email protected]>:
> Hi, Namjae.
>
> Still I found several inconsistent codes and flaws of information across
> the whole patches.
> I've finished changing them, so please review the subsequent patches.
> Thanks,
Hi Jaegeuk.
First, Thank you for taking the time to fill the gaps :)
I checked all updated patches. Looks good to me ~.
Thanks again.

>
> 2013-04-20 (토), 01:28 +0900, Namjae Jeon:
>> From: Namjae Jeon <[email protected]>
>>
>> Add tracepoints in f2fs filesystem for tracing the filesystem
>> operations for information/debugging purpose if needed. All the
>> tracepoints are clubbed with respect to functionalities.
>>
>> Change Log:
>> v4: Modified the tracepoints as per the review comments of
>> Jaegeuk Kim. Following tracepoints are added newly:
>>
>> trace_f2fs_truncate_blocks_enter
>> trace_f2fs_truncate_blocks_exit
>> trace_f2fs_truncate_inode_blocks_enter
>> trace_f2fs_truncate_inode_blocks_exit
>> trace_f2fs_truncate_node
>> trace_f2fs_submit_write_page
>> trace_f2fs_do_submit_bio
>> trace_f2fs_write_checkpoint
>>
>> While some of the tracepoints are modified to add new
>> parameters.
>>
>> v3: Introduced TRACE_EVENT_CONDITION() macro for checking the
>> condition page->mapping inside the trace point function call as
>> per Steve's review comment for the patch
>>
>> v2: Added DECLARE_EVENT_CLASS() macro for combining the similar
>> type of trace function calls which has same type of arguments.
>>
>> v1: Introduced the tracepoint functions in f2fs filesystem.
>>
>> Namjae Jeon (7):
>> f2fs: add tracepoints for sync & Inode operations
>> f2fs: add tracepoints for truncate operation
>> f2fs: add tracepoint for tracing the page i/o operations
>> f2fs: add tracepoints for GC threads
>> f2fs: add tracepoints to debug the block allocation & fallocate
>> f2fs: add tracepoints for write page operations
>> f2fs: add tracepoints to debug checkpoint request
>
> --
> Jaegeuk Kim
> Samsung
>