2013-05-13 10:39:19

by Lad, Prabhakar

Subject: [PATCH] drivers/staging: davinci: vpfe: fix dependency for building the driver

From: Lad, Prabhakar <[email protected]>

from commit 3778d05036cc7ddd983ae2451da579af00acdac2
[media: davinci: kconfig: fix incorrect selects]
VIDEO_VPFE_CAPTURE was removed but there was a negative
dependancy for building the DM365 VPFE MC based capture driver
(VIDEO_DM365_VPFE), This patch fixes this dependency by replacing
the VIDEO_VPFE_CAPTURE with VIDEO_DM365_ISIF, so as when older DM365
ISIF v4l driver is selected the newer media controller driver for
DM365 isnt visible.

Reported-by: Paul Bolle <[email protected]>
Signed-off-by: Lad, Prabhakar <[email protected]>
---
drivers/staging/media/davinci_vpfe/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/Kconfig b/drivers/staging/media/davinci_vpfe/Kconfig
index 2e4a28b..12f321d 100644
--- a/drivers/staging/media/davinci_vpfe/Kconfig
+++ b/drivers/staging/media/davinci_vpfe/Kconfig
@@ -1,6 +1,6 @@
config VIDEO_DM365_VPFE
tristate "DM365 VPFE Media Controller Capture Driver"
- depends on VIDEO_V4L2 && ARCH_DAVINCI_DM365 && !VIDEO_VPFE_CAPTURE
+ depends on VIDEO_V4L2 && ARCH_DAVINCI_DM365 && !VIDEO_DM365_ISIF
select VIDEOBUF2_DMA_CONTIG
help
Support for DM365 VPFE based Media Controller Capture driver.
--
1.7.4.1

2013-05-23 09:36:03

by Lad, Prabhakar

Subject: Re: [PATCH] drivers/staging: davinci: vpfe: fix dependency for building the driver

Hi Hans,

On Mon, May 13, 2013 at 4:09 PM, Lad Prabhakar
<[email protected]> wrote:
> From: Lad, Prabhakar <[email protected]>
>
> from commit 3778d05036cc7ddd983ae2451da579af00acdac2
> [media: davinci: kconfig: fix incorrect selects]
> VIDEO_VPFE_CAPTURE was removed but there was a negative
> dependancy for building the DM365 VPFE MC based capture driver
> (VIDEO_DM365_VPFE), This patch fixes this dependency by replacing
> the VIDEO_VPFE_CAPTURE with VIDEO_DM365_ISIF, so as when older DM365
> ISIF v4l driver is selected the newer media controller driver for
> DM365 isnt visible.
>
Do you plan to take this patch for 3.10 as a fix ? or for v3.11 ?

Regards,
--Prabhakar Lad