2013-06-01 09:40:47

by Thomas Meyer

Subject: [PATCH] HID: hyperv: Cocci spatch "memdup.spatch"

Signed-off-by: Thomas Meyer <[email protected]>
---

diff -u -p a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -199,13 +199,11 @@ static void mousevsc_on_receive_device_i
if (desc->bLength == 0)
goto cleanup;

- input_device->hid_desc = kzalloc(desc->bLength, GFP_ATOMIC);
+ input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);

if (!input_device->hid_desc)
goto cleanup;

- memcpy(input_device->hid_desc, desc, desc->bLength);
-
input_device->report_desc_size = desc->desc[0].wDescriptorLength;
if (input_device->report_desc_size == 0) {
input_device->dev_info_status = -EINVAL;

2013-06-03 11:34:43

by Jiri Kosina

Subject: Re: [PATCH] HID: hyperv: Cocci spatch "memdup.spatch"

On Sat, 1 Jun 2013, Thomas Meyer wrote:

> Signed-off-by: Thomas Meyer <[email protected]>
> ---
>
> diff -u -p a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -199,13 +199,11 @@ static void mousevsc_on_receive_device_i
> if (desc->bLength == 0)
> goto cleanup;
>
> - input_device->hid_desc = kzalloc(desc->bLength, GFP_ATOMIC);
> + input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);
>
> if (!input_device->hid_desc)
> goto cleanup;
>
> - memcpy(input_device->hid_desc, desc, desc->bLength);
> -
> input_device->report_desc_size = desc->desc[0].wDescriptorLength;
> if (input_device->report_desc_size == 0) {
> input_device->dev_info_status = -EINVAL;
>

I guess you are going to get some pushback from some maintainers due to
non-descriptive subject and missing changelog :)

I have fixed this for the hyperv patch and applied it, thanks.

--
Jiri Kosina
SUSE Labs

2013-06-03 14:16:31

by KY Srinivasan

Subject: RE: [PATCH] HID: hyperv: Cocci spatch "memdup.spatch"

> -----Original Message-----
> From: Jiri Kosina [mailto:[email protected]]
> Sent: Monday, June 03, 2013 7:35 AM
> To: Thomas Meyer
> Cc: KY Srinivasan; Haiyang Zhang; [email protected]; linux-
> [email protected]; [email protected]
> Subject: Re: [PATCH] HID: hyperv: Cocci spatch "memdup.spatch"
>
> On Sat, 1 Jun 2013, Thomas Meyer wrote:
>
> > Signed-off-by: Thomas Meyer <[email protected]>
> > ---
> >
> > diff -u -p a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> > --- a/drivers/hid/hid-hyperv.c
> > +++ b/drivers/hid/hid-hyperv.c
> > @@ -199,13 +199,11 @@ static void mousevsc_on_receive_device_i
> > if (desc->bLength == 0)
> > goto cleanup;
> >
> > - input_device->hid_desc = kzalloc(desc->bLength, GFP_ATOMIC);
> > + input_device->hid_desc = kmemdup(desc, desc->bLength,
> GFP_ATOMIC);
> >
> > if (!input_device->hid_desc)
> > goto cleanup;
> >
> > - memcpy(input_device->hid_desc, desc, desc->bLength);
> > -
> > input_device->report_desc_size = desc->desc[0].wDescriptorLength;
> > if (input_device->report_desc_size == 0) {
> > input_device->dev_info_status = -EINVAL;
> >
>
> I guess you are going to get some pushback from some maintainers due to
> non-descriptive subject and missing changelog :)
>
> I have fixed this for the hyperv patch and applied it, thanks.

Thanks Jiri!

K. Y
>
> --
> Jiri Kosina
> SUSE Labs
>