2013-06-14 02:11:50

by Jonghwa Lee

Subject: [PATCH] extcon: class: Add NULL pointer checking for removing notifier block.

This patch adds NULL pointer checking of extcon device to 'extcon_unregister
_interest' which unregisters extcon notifier block.

Signed-off-by: Jonghwa Lee <[email protected]>
Signed-off-by: Myungjoo Ham <[email protected]>
---
drivers/extcon/extcon-class.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
index 8c69803..23f11ea 100644
--- a/drivers/extcon/extcon-class.c
+++ b/drivers/extcon/extcon-class.c
@@ -491,7 +491,7 @@ EXPORT_SYMBOL_GPL(extcon_register_interest);
*/
int extcon_unregister_interest(struct extcon_specific_cable_nb *obj)
{
- if (!obj)
+ if (!obj || !obj->edev)
return -EINVAL;

return raw_notifier_chain_unregister(&obj->edev->nh, &obj->internal_nb);
--
1.7.9.5

2013-06-14 07:18:03

by Chanwoo Choi

Subject: Re: [PATCH] extcon: class: Add NULL pointer checking for removing notifier block.

On 06/14/2013 11:11 AM, Jonghwa Lee wrote:
> This patch adds NULL pointer checking of extcon device to 'extcon_unregister
> _interest' which unregisters extcon notifier block.
>
> Signed-off-by: Jonghwa Lee <[email protected]>
> Signed-off-by: Myungjoo Ham <[email protected]>
> ---
> drivers/extcon/extcon-class.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
> index 8c69803..23f11ea 100644
> --- a/drivers/extcon/extcon-class.c
> +++ b/drivers/extcon/extcon-class.c
> @@ -491,7 +491,7 @@ EXPORT_SYMBOL_GPL(extcon_register_interest);
> */
> int extcon_unregister_interest(struct extcon_specific_cable_nb *obj)
> {
> - if (!obj)
> + if (!obj || !obj->edev)
> return -EINVAL;
>
> return raw_notifier_chain_unregister(&obj->edev->nh, &obj->internal_nb);
>

Applied it.

Thanks,
Chanwoo Choi