2013-07-24 20:20:52

by Stephen Boyd

Subject: [PATCH] gpio_msm: Fix build error due to missing err.h

drivers/gpio/gpio-msm-v1.c: In function 'gpio_msm_v1_probe':
drivers/gpio/gpio-msm-v1.c:656:2:
error: implicit declaration of function 'IS_ERR'
[-Werror=implicit-function-declaration]
drivers/gpio/gpio-msm-v1.c:657:3:
error: implicit declaration of function 'PTR_ERR'
[-Werror=implicit-function-declaration]

This driver failed to compile after commit 68515bb
(gpio_msm: Convert to use devm_ioremap_resource,
2013-06-10).

Cc: Tushar Behera <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/gpio/gpio-msm-v1.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c
index e3ceaac..73b7396 100644
--- a/drivers/gpio/gpio-msm-v1.c
+++ b/drivers/gpio/gpio-msm-v1.c
@@ -21,6 +21,7 @@
#include <linux/module.h>
#include <linux/device.h>
#include <linux/platform_device.h>
+#include <linux/err.h>

#include <mach/msm_gpiomux.h>

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

2013-07-25 03:42:06

by Tushar Behera

Subject: Re: [PATCH] gpio_msm: Fix build error due to missing err.h

On 07/25/2013 01:50 AM, Stephen Boyd wrote:
> drivers/gpio/gpio-msm-v1.c: In function 'gpio_msm_v1_probe':
> drivers/gpio/gpio-msm-v1.c:656:2:
> error: implicit declaration of function 'IS_ERR'
> [-Werror=implicit-function-declaration]
> drivers/gpio/gpio-msm-v1.c:657:3:
> error: implicit declaration of function 'PTR_ERR'
> [-Werror=implicit-function-declaration]
>
> This driver failed to compile after commit 68515bb
> (gpio_msm: Convert to use devm_ioremap_resource,
> 2013-06-10).
>
> Cc: Tushar Behera <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>

Sorry for this. I must have messed up while testing this patchset.

Acked-by: Tushar Behera <[email protected]>


> ---
> drivers/gpio/gpio-msm-v1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c
> index e3ceaac..73b7396 100644
> --- a/drivers/gpio/gpio-msm-v1.c
> +++ b/drivers/gpio/gpio-msm-v1.c
> @@ -21,6 +21,7 @@
> #include <linux/module.h>
> #include <linux/device.h>
> #include <linux/platform_device.h>
> +#include <linux/err.h>
>
> #include <mach/msm_gpiomux.h>
>
>


--
Tushar Behera

2013-07-29 15:37:03

by Linus Walleij

Subject: Re: [PATCH] gpio_msm: Fix build error due to missing err.h

On Wed, Jul 24, 2013 at 10:20 PM, Stephen Boyd <[email protected]> wrote:

> drivers/gpio/gpio-msm-v1.c: In function 'gpio_msm_v1_probe':
> drivers/gpio/gpio-msm-v1.c:656:2:
> error: implicit declaration of function 'IS_ERR'
> [-Werror=implicit-function-declaration]
> drivers/gpio/gpio-msm-v1.c:657:3:
> error: implicit declaration of function 'PTR_ERR'
> [-Werror=implicit-function-declaration]
>
> This driver failed to compile after commit 68515bb
> (gpio_msm: Convert to use devm_ioremap_resource,
> 2013-06-10).
>
> Cc: Tushar Behera <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>

Thanks, patch applied and queued for fixes.

Yours,
Linus Walleij