2013-09-23 03:47:11

by Sonic Zhang

Subject: [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig.

From: Sonic Zhang <[email protected]>

Signed-off-by: Sonic Zhang <[email protected]>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 08b8337..9bb6efb 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -51,6 +51,7 @@ config PINCTRL_AB8505

config PINCTRL_ADI2
bool "ADI pin controller driver"
+ depends on BLACKFIN
select PINMUX
select IRQ_DOMAIN
help
--
1.8.2.3

2013-09-23 07:43:41

by Linus Walleij

Subject: Re: [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig.

On Mon, Sep 23, 2013 at 5:57 AM, Sonic Zhang <[email protected]> wrote:

> From: Sonic Zhang <[email protected]>
>
> Signed-off-by: Sonic Zhang <[email protected]>

Patch applied, will push immediately so linux-next builds.

Yours,
Linus Walleij

2013-09-23 07:45:30

by Dan Carpenter

Subject: Re: [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig.

The other two Coccinelle warnings were real bugs as well:

drivers/pinctrl/pinctrl-adi2.c:250:1-18: ERROR: nested lock+irqsave that reuses flags from line 249.
The second spinlock_irq_save() should just be a spinlock.

drivers/pinctrl/pinctrl-adi2.c:326:16-19: ERROR: port is NULL but dereferenced.
The error message dereferences a NULL pointer.

regards,
dan carpenter