2014-02-12 09:41:13

by Paul Bolle

Subject: [PATCH] ARM: S3C24XX: Fix typo "CONFIG_CPUS_3C2443"

Signed-off-by: Paul Bolle <[email protected]>
---
Untested. This needs testing by people with access to knowledge,
compilers, and/or hardware related to CPU_S3C2443. I'm not one of them.

arch/arm/mach-s3c24xx/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c
index 4adaa4b..1d77d70 100644
--- a/arch/arm/mach-s3c24xx/common.c
+++ b/arch/arm/mach-s3c24xx/common.c
@@ -484,7 +484,7 @@ struct platform_device s3c2440_device_dma = {
};
#endif

-#if defined(CONFIG_CPUS_3C2443) || defined(CONFIG_CPU_S3C2416)
+#if defined(CONFIG_CPU_S3C2443) || defined(CONFIG_CPU_S3C2416)
static struct resource s3c2443_dma_resource[] = {
[0] = DEFINE_RES_MEM(S3C24XX_PA_DMA, S3C24XX_SZ_DMA),
[1] = DEFINE_RES_IRQ(IRQ_S3C2443_DMA0),
--
1.8.5.3

2014-02-12 09:47:32

by Sachin Kamat

Subject: Re: [PATCH] ARM: S3C24XX: Fix typo "CONFIG_CPUS_3C2443"

On 12 February 2014 15:11, Paul Bolle <[email protected]> wrote:
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> Untested. This needs testing by people with access to knowledge,
> compilers, and/or hardware related to CPU_S3C2443. I'm not one of them.
>
> arch/arm/mach-s3c24xx/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c
> index 4adaa4b..1d77d70 100644
> --- a/arch/arm/mach-s3c24xx/common.c
> +++ b/arch/arm/mach-s3c24xx/common.c
> @@ -484,7 +484,7 @@ struct platform_device s3c2440_device_dma = {
> };
> #endif
>
> -#if defined(CONFIG_CPUS_3C2443) || defined(CONFIG_CPU_S3C2416)
> +#if defined(CONFIG_CPU_S3C2443) || defined(CONFIG_CPU_S3C2416)

This is definitely a typo and the current fix looks good.

Reviewed-by: Sachin Kamat <[email protected]>

--
With warm regards,
Sachin

2014-02-13 22:33:20

by Kukjin Kim

Subject: Re: [PATCH] ARM: S3C24XX: Fix typo "CONFIG_CPUS_3C2443"

On 02/12/14 18:47, Sachin Kamat wrote:
> On 12 February 2014 15:11, Paul Bolle<[email protected]> wrote:
>> Signed-off-by: Paul Bolle<[email protected]>
>> ---
>> Untested. This needs testing by people with access to knowledge,
>> compilers, and/or hardware related to CPU_S3C2443. I'm not one of them.
>>
>> arch/arm/mach-s3c24xx/common.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c
>> index 4adaa4b..1d77d70 100644
>> --- a/arch/arm/mach-s3c24xx/common.c
>> +++ b/arch/arm/mach-s3c24xx/common.c
>> @@ -484,7 +484,7 @@ struct platform_device s3c2440_device_dma = {
>> };
>> #endif
>>
>> -#if defined(CONFIG_CPUS_3C2443) || defined(CONFIG_CPU_S3C2416)
>> +#if defined(CONFIG_CPU_S3C2443) || defined(CONFIG_CPU_S3C2416)
>
> This is definitely a typo and the current fix looks good.
>
> Reviewed-by: Sachin Kamat<[email protected]>
>
Applied, thanks.

- Kukjin