2014-02-19 10:13:44

by Alexander Gordeev

Subject: [PATCH] ioat: Use pci_enable_msix_range() instead of pci_enable_msix()

As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() and pci_enable_msix_range()
interfaces.

Signed-off-by: Alexander Gordeev <[email protected]>
Cc: Dan Williams <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/dma/ioat/dma.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index 8752918..af0d8b1 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/ioat/dma.c
@@ -909,8 +909,9 @@ msix:
for (i = 0; i < msixcnt; i++)
device->msix_entries[i].entry = i;

- err = pci_enable_msix(pdev, device->msix_entries, msixcnt);
- if (err)
+ err = pci_enable_msix_range(pdev,
+ device->msix_entries, msixcnt, msixcnt);
+ if (err < 0)
goto msi;

for (i = 0; i < msixcnt; i++) {
--
1.7.7.6

2014-02-21 16:19:24

by Alexander Gordeev

Subject: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()

As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.

Signed-off-by: Alexander Gordeev <[email protected]>
Cc: Dan Williams <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/dma/ioat/dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index 8752918..7bc9e6f 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/ioat/dma.c
@@ -909,7 +909,7 @@ msix:
for (i = 0; i < msixcnt; i++)
device->msix_entries[i].entry = i;

- err = pci_enable_msix(pdev, device->msix_entries, msixcnt);
+ err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt);
if (err)
goto msi;

--
1.7.7.6

--
Regards,
Alexander Gordeev
[email protected]

2014-04-21 13:46:13

by Alexander Gordeev

Subject: Re: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()

On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Function pci_enable_msix() returns a tri-state value while
> pci_enable_msi_exact() is a canonical zero/-errno variant.
> The former is being phased out in favor of the latter.
> In case of 'ioat' there (should be) no difference.
>
> Signed-off-by: Alexander Gordeev <[email protected]>
> Cc: Dan Williams <[email protected]>
> Cc: Vinod Koul <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Acked-by: Dan Williams <[email protected]>

Hi Dan,

Would you pick this patch, please?

Thanks!

--
Regards,
Alexander Gordeev
[email protected]