2014-02-20 16:09:09

by Kumar Gala

[permalink] [raw]
Subject: [PATCH v2] hwrng: msm: switch Kconfig to ARCH_QCOM depends

We've split Qualcomm MSM support into legacy and multiplatform. The RNG
driver is only relevant on the multiplatform supported SoCs so switch the
Kconfig depends to ARCH_QCOM.

CC: Herbert Xu <[email protected]>
CC: Stanimir Varbanov <[email protected]>
Signed-off-by: Kumar Gala <[email protected]>
---

Herbert,

If you can ack this I'll send it via linux-qcom/arm-soc tree's

thanks

v2:
* Updated help text to remove MSM references, made more generic

drivers/char/hw_random/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 2f2b084..f2b9f8c 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -342,11 +342,11 @@ config HW_RANDOM_TPM
If unsure, say Y.

config HW_RANDOM_MSM
- tristate "Qualcomm MSM Random Number Generator support"
- depends on HW_RANDOM && ARCH_MSM
+ tristate "Qualcomm ARM SoCs Random Number Generator support"
+ depends on HW_RANDOM && ARCH_QCOM
---help---
This driver provides kernel-side support for the Random Number
- Generator hardware found on Qualcomm MSM SoCs.
+ Generator hardware found on Qualcomm ARM SoCs.

To compile this driver as a module, choose M here. the
module will be called msm-rng.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation


2014-02-20 18:42:22

by Christopher Covington

[permalink] [raw]
Subject: Re: [PATCH v2] hwrng: msm: switch Kconfig to ARCH_QCOM depends

On 02/20/2014 11:09 AM, Kumar Gala wrote:
> We've split Qualcomm MSM support into legacy and multiplatform. The RNG
> driver is only relevant on the multiplatform supported SoCs so switch the
> Kconfig depends to ARCH_QCOM.
>
> CC: Herbert Xu <[email protected]>
> CC: Stanimir Varbanov <[email protected]>
> Signed-off-by: Kumar Gala <[email protected]>
> ---
>
> Herbert,
>
> If you can ack this I'll send it via linux-qcom/arm-soc tree's
>
> thanks
>
> v2:
> * Updated help text to remove MSM references, made more generic
>
> drivers/char/hw_random/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 2f2b084..f2b9f8c 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -342,11 +342,11 @@ config HW_RANDOM_TPM
> If unsure, say Y.
>
> config HW_RANDOM_MSM
> - tristate "Qualcomm MSM Random Number Generator support"

> + tristate "Qualcomm ARM SoCs Random Number Generator support"

Can the Hexagon use the PRNG, at least theoretically? If so maybe it'd be
clearest to leave ARM off.

Christopher

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.

2014-02-20 21:54:43

by Kumar Gala

[permalink] [raw]
Subject: Re: [PATCH v2] hwrng: msm: switch Kconfig to ARCH_QCOM depends


On Feb 20, 2014, at 12:42 PM, Christopher Covington <[email protected]> wrote:

> On 02/20/2014 11:09 AM, Kumar Gala wrote:
>> We've split Qualcomm MSM support into legacy and multiplatform. The RNG
>> driver is only relevant on the multiplatform supported SoCs so switch the
>> Kconfig depends to ARCH_QCOM.
>>
>> CC: Herbert Xu <[email protected]>
>> CC: Stanimir Varbanov <[email protected]>
>> Signed-off-by: Kumar Gala <[email protected]>
>> ---
>>
>> Herbert,
>>
>> If you can ack this I'll send it via linux-qcom/arm-soc tree's
>>
>> thanks
>>
>> v2:
>> * Updated help text to remove MSM references, made more generic
>>
>> drivers/char/hw_random/Kconfig | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
>> index 2f2b084..f2b9f8c 100644
>> --- a/drivers/char/hw_random/Kconfig
>> +++ b/drivers/char/hw_random/Kconfig
>> @@ -342,11 +342,11 @@ config HW_RANDOM_TPM
>> If unsure, say Y.
>>
>> config HW_RANDOM_MSM
>> - tristate "Qualcomm MSM Random Number Generator support"
>
>> + tristate "Qualcomm ARM SoCs Random Number Generator support"
>
> Can the Hexagon use the PRNG, at least theoretically? If so maybe it'd be
> clearest to leave ARM off.
>
> Christopher

Fair point.

- k


--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation