Instead of requiring user to figure out when PHY_EXYNOS_MIPI_VIDEO needs
to be selected select it by default for Exynos SoCs. Also enable it when
COMPILE_TEST is selected. If required the MIPI CSIS/DPHY driver can be
then disabled or compiled in as module.
Signed-off-by: Sylwester Nawrocki <[email protected]>
Acked-by: Kyungmin Park <[email protected]>
---
Changes since first version:
- use ARCH_EXYNOS instead of "ARCH_EXYNOS4 || ARCH_EXYNOS5"
- add dependency on COMPILE_TEST, and ARCH_S5PV210 for
PHY_EXYNOS_MIPI_VIDEO
---
drivers/phy/Kconfig | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index afa2354..ebd455c 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -16,8 +16,11 @@ config GENERIC_PHY
framework should select this config.
config PHY_EXYNOS_MIPI_VIDEO
- depends on HAS_IOMEM
tristate "S5P/EXYNOS SoC series MIPI CSI-2/DSI PHY driver"
+ depends on HAS_IOMEM
+ depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
+ select GENERIC_PHY
+ default y
help
Support for MIPI CSI-2 and MIPI DSI DPHY found on Samsung S5P
and EXYNOS SoCs.
--
1.7.9.5
Instead of requiring user to figure out when PHY_EXYNOS_DP_VIDEO needs
to be selected select it by default for Exynos SoCs. Also enable it
when COMPILE_TEST is selected. If required the display port PHY driver
can be then disabled or compiled in as module.
Cc: Jingoo Han <[email protected]>
Signed-off-by: Sylwester Nawrocki <[email protected]>
Acked-by: Kyungmin Park <[email protected]>
---
Changes since first version:
- use ARCH_EXYNOS instead of "ARCH_EXYNOS4 || ARCH_EXYNOS5"
- add dependency on COMPILE_TEST
---
drivers/phy/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index ebd455c..4218c99 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -57,6 +57,8 @@ config TWL4030_USB
config PHY_EXYNOS_DP_VIDEO
tristate "EXYNOS SoC series Display Port PHY driver"
depends on OF
+ depends on ARCH_EXYNOS || COMPILE_TEST
+ default y
select GENERIC_PHY
help
Support for Display Port PHY found on Samsung EXYNOS SoCs.
--
1.7.9.5
On Friday 21 February 2014 16:50:02 Sylwester Nawrocki wrote:
> config PHY_EXYNOS_DP_VIDEO
> tristate "EXYNOS SoC series Display Port PHY driver"
> depends on OF
> + depends on ARCH_EXYNOS || COMPILE_TEST
> + default y
> select GENERIC_PHY
> help
>
That would turn them on automatically if you enable COMPILE_TEST, which
is probably not what you want.
How about "default ARCH_EXYNOS"?
Arnd
On 21/02/14 16:59, Arnd Bergmann wrote:
> On Friday 21 February 2014 16:50:02 Sylwester Nawrocki wrote:
>> config PHY_EXYNOS_DP_VIDEO
>> tristate "EXYNOS SoC series Display Port PHY driver"
>> depends on OF
>> + depends on ARCH_EXYNOS || COMPILE_TEST
>> + default y
>> select GENERIC_PHY
>> help
>>
>
> That would turn them on automatically if you enable COMPILE_TEST, which
> is probably not what you want.
>
> How about "default ARCH_EXYNOS"?
Hmm, good point, I will modify it that way.
For patch 1/2 I guess it should be:
"default ARCH_S5PV210 || ARCH_EXYNOS"
or rather
"default y if ARCH_S5PV210 || ARCH_EXYNOS" ?
Thanks,
Sylwester
On Friday 21 February 2014 17:25:04 Sylwester Nawrocki wrote:
>
> Hmm, good point, I will modify it that way.
>
> For patch 1/2 I guess it should be:
>
> "default ARCH_S5PV210 || ARCH_EXYNOS"
>
> or rather
>
> "default y if ARCH_S5PV210 || ARCH_EXYNOS" ?
Right. I'd probably use the first syntax, but it doesn't really matter.
Arnd
On 21/02/14 17:41, Arnd Bergmann wrote:
> On Friday 21 February 2014 17:25:04 Sylwester Nawrocki wrote:
>> >
>> > Hmm, good point, I will modify it that way.
>> >
>> > For patch 1/2 I guess it should be:
>> >
>> > "default ARCH_S5PV210 || ARCH_EXYNOS"
>> >
>> > or rather
>> >
>> > "default y if ARCH_S5PV210 || ARCH_EXYNOS" ?
>
> Right. I'd probably use the first syntax, but it doesn't really matter.
Oops, I've already sent patch using the second one, as it seemed
more common.
Thanks,
Sylwester
On Friday 21 February 2014 17:50:44 Sylwester Nawrocki wrote:
> On 21/02/14 17:41, Arnd Bergmann wrote:
> > On Friday 21 February 2014 17:25:04 Sylwester Nawrocki wrote:
> >> >
> >> > Hmm, good point, I will modify it that way.
> >> >
> >> > For patch 1/2 I guess it should be:
> >> >
> >> > "default ARCH_S5PV210 || ARCH_EXYNOS"
> >> >
> >> > or rather
> >> >
> >> > "default y if ARCH_S5PV210 || ARCH_EXYNOS" ?
> >
> > Right. I'd probably use the first syntax, but it doesn't really matter.
>
> Oops, I've already sent patch using the second one, as it seemed
> more common.
As I said, it doesn't matter.
Arnd