2014-02-26 05:08:07

by Pankaj Dubey

[permalink] [raw]
Subject: [PATCH 0/3] introduce new config option for samsung common clock

This patchset introduces a new config option for Samsung
common clock infrastructure as COMMON_CLK_SAMSUNG. As current
samsung common clock gets compiled based on PLAT_SAMSUNG, but moving
ahead with ARM64 we can not have any more such config options, so
better we introduce new COMMON_CLK_SAMSUNG and make it dependent
on existing ARCH_XXXX which needs SAMSUNG common clock infrastructure, also
on ARM64.

Pankaj Dubey (3):
drivers: clk: add samsung common clock config option
ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX
ARM: S3C24XX: select COMMON_CLK_SAMSUNG for S3C24XX

arch/arm/Kconfig | 2 ++
arch/arm/mach-s3c24xx/Kconfig | 3 +++
drivers/clk/Kconfig | 10 ++++++++++
drivers/clk/Makefile | 2 +-
4 files changed, 16 insertions(+), 1 deletion(-)

--
1.7.9.5


2014-02-26 05:08:13

by Pankaj Dubey

[permalink] [raw]
Subject: [PATCH 1/3] drivers: clk: add samsung common clock config option

add samsung common clock config option and let ARCH_EXYNOS or ARCH_S3CXXXX
select this if they want to use samsung common clock infrastructure.

CC: Mike Turquette <[email protected]>
Signed-off-by: Pankaj Dubey <[email protected]>
---
drivers/clk/Kconfig | 10 ++++++++++
drivers/clk/Makefile | 2 +-
2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 7641965..d93a325 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -23,6 +23,16 @@ config COMMON_CLK
menu "Common Clock Framework"
depends on COMMON_CLK

+config COMMON_CLK_SAMSUNG
+ bool "Clock driver for Samsung SoCs"
+ depends on ARCH_S3C64XX || ARCH_S3C24XX || ARCH_EXYNOS || ARM64
+ ---help---
+ Supports clocking on Exynos SoCs:
+ - Exynos5250, Exynos5420 board.
+ - Exynos4 boards.
+ - S3C2412, S3C2416, S3C2466 boards.
+ - S3C64XX boards.
+
config COMMON_CLK_WM831X
tristate "Clock driver for WM831x/2x PMICs"
depends on MFD_WM831X
diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
index a367a98..f1da6ee 100644
--- a/drivers/clk/Makefile
+++ b/drivers/clk/Makefile
@@ -38,7 +38,7 @@ obj-$(CONFIG_PLAT_ORION) += mvebu/
obj-$(CONFIG_ARCH_MXS) += mxs/
obj-$(CONFIG_COMMON_CLK_QCOM) += qcom/
obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/
-obj-$(CONFIG_PLAT_SAMSUNG) += samsung/
+obj-$(CONFIG_COMMON_CLK_SAMSUNG) += samsung/
obj-$(CONFIG_ARCH_SHMOBILE_MULTI) += shmobile/
obj-$(CONFIG_ARCH_SIRF) += sirf/
obj-$(CONFIG_ARCH_SOCFPGA) += socfpga/
--
1.7.9.5

2014-02-26 05:08:17

by Pankaj Dubey

[permalink] [raw]
Subject: [PATCH 3/3] ARM: S3C24XX: select COMMON_CLK_SAMSUNG for S3C24XX

CC: Ben Dooks <[email protected]>
CC: Kukjin Kim <[email protected]>
CC: Russell King <[email protected]>
Signed-off-by: Pankaj Dubey <[email protected]>
---
arch/arm/mach-s3c24xx/Kconfig | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index 80373da..5cf82a1 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -40,6 +40,7 @@ config CPU_S3C2410
config CPU_S3C2412
bool "SAMSUNG S3C2412"
select COMMON_CLK
+ select COMMON_CLK_SAMSUNG
select CPU_ARM926T
select CPU_LLSERIAL_S3C2440
select S3C2412_COMMON_CLK
@@ -51,6 +52,7 @@ config CPU_S3C2412
config CPU_S3C2416
bool "SAMSUNG S3C2416/S3C2450"
select COMMON_CLK
+ select COMMON_CLK_SAMSUNG
select CPU_ARM926T
select CPU_LLSERIAL_S3C2440
select S3C2416_PM if PM
@@ -89,6 +91,7 @@ config CPU_S3C244X
config CPU_S3C2443
bool "SAMSUNG S3C2443"
select COMMON_CLK
+ select COMMON_CLK_SAMSUNG
select CPU_ARM920T
select CPU_LLSERIAL_S3C2440
select S3C2443_COMMON_CLK
--
1.7.9.5

2014-02-26 05:08:25

by Pankaj Dubey

[permalink] [raw]
Subject: [PATCH 2/3] ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX

CC: Russell King <[email protected]>
Signed-off-by: Pankaj Dubey <[email protected]>
---
arch/arm/Kconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e254198..cc8868d 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -756,6 +756,7 @@ config ARCH_S3C64XX
select CLKDEV_LOOKUP
select CLKSRC_SAMSUNG_PWM
select COMMON_CLK
+ select COMMON_CLK_SAMSUNG
select CPU_V6K
select GENERIC_CLOCKEVENTS
select GPIO_SAMSUNG
@@ -835,6 +836,7 @@ config ARCH_EXYNOS
select ARCH_SPARSEMEM_ENABLE
select ARM_GIC
select COMMON_CLK
+ select COMMON_CLK_SAMSUNG
select CPU_V7
select GENERIC_CLOCKEVENTS
select HAVE_S3C2410_I2C if I2C
--
1.7.9.5

2014-02-27 00:16:30

by Mike Turquette

[permalink] [raw]
Subject: Re: [PATCH 3/3] ARM: S3C24XX: select COMMON_CLK_SAMSUNG for S3C24XX

Quoting Pankaj Dubey (2014-02-25 21:24:07)
> CC: Ben Dooks <[email protected]>
> CC: Kukjin Kim <[email protected]>
> CC: Russell King <[email protected]>
> Signed-off-by: Pankaj Dubey <[email protected]>
> ---
> arch/arm/mach-s3c24xx/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
> index 80373da..5cf82a1 100644
> --- a/arch/arm/mach-s3c24xx/Kconfig
> +++ b/arch/arm/mach-s3c24xx/Kconfig
> @@ -40,6 +40,7 @@ config CPU_S3C2410
> config CPU_S3C2412
> bool "SAMSUNG S3C2412"
> select COMMON_CLK
> + select COMMON_CLK_SAMSUNG

I guess this depends on Heiko's "[PATCH 00/12] ARM: S3C24XX: convert
s3c2410, s3c2440 s3c2442 to common clock framework" series?

Regards,
Mike

> select CPU_ARM926T
> select CPU_LLSERIAL_S3C2440
> select S3C2412_COMMON_CLK
> @@ -51,6 +52,7 @@ config CPU_S3C2412
> config CPU_S3C2416
> bool "SAMSUNG S3C2416/S3C2450"
> select COMMON_CLK
> + select COMMON_CLK_SAMSUNG
> select CPU_ARM926T
> select CPU_LLSERIAL_S3C2440
> select S3C2416_PM if PM
> @@ -89,6 +91,7 @@ config CPU_S3C244X
> config CPU_S3C2443
> bool "SAMSUNG S3C2443"
> select COMMON_CLK
> + select COMMON_CLK_SAMSUNG
> select CPU_ARM920T
> select CPU_LLSERIAL_S3C2440
> select S3C2443_COMMON_CLK
> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2014-02-27 01:32:15

by Pankaj Dubey

[permalink] [raw]
Subject: Re: [PATCH 3/3] ARM: S3C24XX: select COMMON_CLK_SAMSUNG for S3C24XX

On 02/27/2014 09:16 AM, Mike Turquette wrote:
> Quoting Pankaj Dubey (2014-02-25 21:24:07)
>> CC: Ben Dooks <[email protected]>
>> CC: Kukjin Kim <[email protected]>
>> CC: Russell King <[email protected]>
>> Signed-off-by: Pankaj Dubey <[email protected]>
>> ---
>> arch/arm/mach-s3c24xx/Kconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
>> index 80373da..5cf82a1 100644
>> --- a/arch/arm/mach-s3c24xx/Kconfig
>> +++ b/arch/arm/mach-s3c24xx/Kconfig
>> @@ -40,6 +40,7 @@ config CPU_S3C2410
>> config CPU_S3C2412
>> bool "SAMSUNG S3C2412"
>> select COMMON_CLK
>> + select COMMON_CLK_SAMSUNG
> I guess this depends on Heiko's "[PATCH 00/12] ARM: S3C24XX: convert
> s3c2410, s3c2440 s3c2442 to common clock framework" series?
>
> Regards,
> Mike

Yes, this series is based on latest kgene/for-next branch where Heiko's
series is merged.

>> select CPU_ARM926T
>> select CPU_LLSERIAL_S3C2440
>> select S3C2412_COMMON_CLK
>> @@ -51,6 +52,7 @@ config CPU_S3C2412
>> config CPU_S3C2416
>> bool "SAMSUNG S3C2416/S3C2450"
>> select COMMON_CLK
>> + select COMMON_CLK_SAMSUNG
>> select CPU_ARM926T
>> select CPU_LLSERIAL_S3C2440
>> select S3C2416_PM if PM
>> @@ -89,6 +91,7 @@ config CPU_S3C244X
>> config CPU_S3C2443
>> bool "SAMSUNG S3C2443"
>> select COMMON_CLK
>> + select COMMON_CLK_SAMSUNG
>> select CPU_ARM920T
>> select CPU_LLSERIAL_S3C2440
>> select S3C2443_COMMON_CLK
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> [email protected]
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


--
Best Regards,
Pankaj Dubey

2014-02-27 07:00:36

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH 3/3] ARM: S3C24XX: select COMMON_CLK_SAMSUNG for S3C24XX

Am Donnerstag, 27. Februar 2014, 10:48:26 schrieb Pankaj Dubey:
> On 02/27/2014 09:16 AM, Mike Turquette wrote:
> > Quoting Pankaj Dubey (2014-02-25 21:24:07)
> >
> >> CC: Ben Dooks <[email protected]>
> >> CC: Kukjin Kim <[email protected]>
> >> CC: Russell King <[email protected]>
> >> Signed-off-by: Pankaj Dubey <[email protected]>
> >> ---
> >>
> >> arch/arm/mach-s3c24xx/Kconfig | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/arch/arm/mach-s3c24xx/Kconfig
> >> b/arch/arm/mach-s3c24xx/Kconfig
> >> index 80373da..5cf82a1 100644
> >> --- a/arch/arm/mach-s3c24xx/Kconfig
> >> +++ b/arch/arm/mach-s3c24xx/Kconfig
> >> @@ -40,6 +40,7 @@ config CPU_S3C2410
> >>
> >> config CPU_S3C2412
> >>
> >> bool "SAMSUNG S3C2412"
> >> select COMMON_CLK
> >>
> >> + select COMMON_CLK_SAMSUNG
> >
> > I guess this depends on Heiko's "[PATCH 00/12] ARM: S3C24XX: convert
> > s3c2410, s3c2440 s3c2442 to common clock framework" series?
> >
> > Regards,
> > Mike
>
> Yes, this series is based on latest kgene/for-next branch where Heiko's
> series is merged.

Just to clarify, converted are the s3c2416/s3c2443 (first series) and s3c2412
(second series), because the clockout for s3c2410 etc seems to need a bit more
work. I've just moved two comon patches (shared plls and a platform change)
from the s3c2410,et-all series into the s3c2412 one.

Both of these series are merged in kgenes tree as mentioned. And at this point
I'm not sure if I will have the time to respin the s3c2410 series for 3.15.
Which might also be good to let all the other series touching samsung clock
code settle.


Heiko

>
> >> select CPU_ARM926T
> >> select CPU_LLSERIAL_S3C2440
> >> select S3C2412_COMMON_CLK
> >>
> >> @@ -51,6 +52,7 @@ config CPU_S3C2412
> >>
> >> config CPU_S3C2416
> >>
> >> bool "SAMSUNG S3C2416/S3C2450"
> >> select COMMON_CLK
> >>
> >> + select COMMON_CLK_SAMSUNG
> >>
> >> select CPU_ARM926T
> >> select CPU_LLSERIAL_S3C2440
> >> select S3C2416_PM if PM
> >>
> >> @@ -89,6 +91,7 @@ config CPU_S3C244X
> >>
> >> config CPU_S3C2443
> >>
> >> bool "SAMSUNG S3C2443"
> >> select COMMON_CLK
> >>
> >> + select COMMON_CLK_SAMSUNG
> >>
> >> select CPU_ARM920T
> >> select CPU_LLSERIAL_S3C2440
> >> select S3C2443_COMMON_CLK
> >>
> >> _______________________________________________
> >> linux-arm-kernel mailing list
> >> [email protected]
> >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel