2014-04-10 18:02:47

by Tim Gardner

Subject: [PATCH] ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops

BugLink: http://bugs.launchpad.net/bugs/1305480

The kerneloops-daemon scans dmesg for common crash signatures, among
which is 'BUG:'. The message emitted by the PCM library is really a
warning, so the most expedient thing to do seems to be to change the
string.

Cc: Jaroslav Kysela <[email protected]>
Cc: Takashi Iwai <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>
Cc: JongHo Kim <[email protected]>
Signed-off-by: Tim Gardner <[email protected]>
---
sound/core/pcm_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index ce83def..2a0563d 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -345,7 +345,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream,
snd_pcm_debug_name(substream, name, sizeof(name));
xrun_log_show(substream);
pcm_err(substream->pcm,
- "BUG: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
+ "OVER RUN: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
name, pos, runtime->buffer_size,
runtime->period_size);
}
--
1.7.9.5

2014-04-11 15:20:51

by Takashi Iwai

Subject: Re: [PATCH] ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops

At Thu, 10 Apr 2014 10:45:08 -0600,
Tim Gardner wrote:
>
> BugLink: http://bugs.launchpad.net/bugs/1305480
>
> The kerneloops-daemon scans dmesg for common crash signatures, among
> which is 'BUG:'. The message emitted by the PCM library is really a
> warning, so the most expedient thing to do seems to be to change the
> string.
>
> Cc: Jaroslav Kysela <[email protected]>
> Cc: Takashi Iwai <[email protected]>
> Cc: Mark Brown <[email protected]>
> Cc: Lars-Peter Clausen <[email protected]>
> Cc: JongHo Kim <[email protected]>
> Signed-off-by: Tim Gardner <[email protected]>
> ---
> sound/core/pcm_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
> index ce83def..2a0563d 100644
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -345,7 +345,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream,
> snd_pcm_debug_name(substream, name, sizeof(name));
> xrun_log_show(substream);
> pcm_err(substream->pcm,
> - "BUG: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
> + "OVER RUN: %s, pos = %ld, buffer size = %ld, period size = %ld\n",

Use a term "XRUN", as it's not always an overrun.


thanks,

Takashi