2014-04-22 16:38:22

by Phil Edworthy

Subject: [PATCH] sh-pfc: r8a7791: Fix definition of MOD_SEL3

There is a missing 0 entry from the MOD_SEL3 table.

Signed-off-by: Phil Edworthy <[email protected]>
---
drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
index 56f62dc..a823b5b 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
@@ -5305,7 +5305,7 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
/* SEL_SCIF3 [2] */
FN_SEL_SCIF3_0, FN_SEL_SCIF3_1, FN_SEL_SCIF3_2, FN_SEL_SCIF3_3,
/* SEL_IEB [2] */
- FN_SEL_IEB_0, FN_SEL_IEB_1, FN_SEL_IEB_2,
+ FN_SEL_IEB_0, FN_SEL_IEB_1, FN_SEL_IEB_2, 0,
/* SEL_MMC [1] */
FN_SEL_MMC_0, FN_SEL_MMC_1,
/* SEL_SCIF5 [1] */
--
1.9.1

2014-04-22 16:39:24

by Laurent Pinchart

Subject: Re: [PATCH] sh-pfc: r8a7791: Fix definition of MOD_SEL3

Hi Phil,

Thank you for the patch.

On Tuesday 22 April 2014 17:38:05 Phil Edworthy wrote:
> There is a missing 0 entry from the MOD_SEL3 table.
>
> Signed-off-by: Phil Edworthy <[email protected]>

Acked-by: Laurent Pinchart <[email protected]>

> ---
> drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c index 56f62dc..a823b5b 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> @@ -5305,7 +5305,7 @@ static const struct pinmux_cfg_reg
> pinmux_config_regs[] = { /* SEL_SCIF3 [2] */
> FN_SEL_SCIF3_0, FN_SEL_SCIF3_1, FN_SEL_SCIF3_2, FN_SEL_SCIF3_3,
> /* SEL_IEB [2] */
> - FN_SEL_IEB_0, FN_SEL_IEB_1, FN_SEL_IEB_2,
> + FN_SEL_IEB_0, FN_SEL_IEB_1, FN_SEL_IEB_2, 0,
> /* SEL_MMC [1] */
> FN_SEL_MMC_0, FN_SEL_MMC_1,
> /* SEL_SCIF5 [1] */

--
Regards,

Laurent Pinchart

2014-04-23 14:10:29

by Linus Walleij

Subject: Re: [PATCH] sh-pfc: r8a7791: Fix definition of MOD_SEL3

On Tue, Apr 22, 2014 at 6:38 PM, Phil Edworthy
<[email protected]> wrote:

> There is a missing 0 entry from the MOD_SEL3 table.
>
> Signed-off-by: Phil Edworthy <[email protected]>

Patch applied for fixes with Laurent's ACK.

Yours,
Linus Walleij