2013-07-04 04:59:12

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warnings in Linus' tree

Hi all,

Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
produced this warning (these have been around for a while):

drivers/infiniband/hw/nes/nes_hw.c:81:23: warning: 'nes_iwarp_state_str' defined but not used [-Wunused-variable]
static unsigned char *nes_iwarp_state_str[] = {
^
drivers/infiniband/hw/nes/nes_hw.c:92:23: warning: 'nes_tcp_state_str' defined but not used [-Wunused-variable]
static unsigned char *nes_tcp_state_str[] = {
^

Introduced by commit bca1935ccdec ("RDMA/nes: Fix compilation error when
nes_debug is enabled").

--
Cheers,
Stephen Rothwell [email protected]


Attachments:
(No filename) (679.00 B)
(No filename) (836.00 B)
Download all attachments

2013-07-09 21:48:49

by Nikolova, Tatyana E

[permalink] [raw]
Subject: RE: linux-next: build warnings in Linus' tree

Hello Stephen,

Thank you for reporting the error. I removed these variables from the debug statement, because I didn't see that they were defined. It is possible that I manually enabled the nes_debug and the #ifdef CONFIG_INFINIBAND_NES_DEBUG statement these variables are enclosed in wasn't true, so I saw a compilation issue.

Feel free to revert the commit bca1935ccdec ("RDMA/nes: Fix compilation error when nes_debug is enabled") or I will submit a patch to address the issue next week.

Regards,
Tatyana

-----Original Message-----
From: Stephen Rothwell [mailto:[email protected]]
Sent: Wednesday, July 03, 2013 11:59 PM
To: Roland Dreier
Cc: [email protected]; [email protected]; Nikolova, Tatyana E
Subject: linux-next: build warnings in Linus' tree

Hi all,

Building Linus' tree, today's linux-next build (x86_64 allmodconfig) produced this warning (these have been around for a while):

drivers/infiniband/hw/nes/nes_hw.c:81:23: warning: 'nes_iwarp_state_str' defined but not used [-Wunused-variable] static unsigned char *nes_iwarp_state_str[] = {
^
drivers/infiniband/hw/nes/nes_hw.c:92:23: warning: 'nes_tcp_state_str' defined but not used [-Wunused-variable] static unsigned char *nes_tcp_state_str[] = {
^

Introduced by commit bca1935ccdec ("RDMA/nes: Fix compilation error when nes_debug is enabled").

--
Cheers,
Stephen Rothwell [email protected]