2014-07-09 06:07:28

by Anil Belur

Subject: [PATCH 1/2] staging: media: bcm2048: radio-bcm2048.c - removed IRQF_DISABLED macro

From: Anil Belur <[email protected]>

- this patch removes IRQF_DISABLED macro, as this is
deprecated/noop.

Signed-off-by: Anil Belur <[email protected]>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index bbf236e..8760eca 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2618,7 +2618,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client *client,

if (client->irq) {
err = request_irq(client->irq,
- bcm2048_handler, IRQF_TRIGGER_FALLING | IRQF_DISABLED,
+ bcm2048_handler, IRQF_TRIGGER_FALLING,
client->name, bdev);
if (err < 0) {
dev_err(&client->dev, "Could not request IRQ\n");
--
1.9.1

2014-07-09 06:07:46

by Anil Belur

Subject: [PATCH 2/2] staging: nokia_h4p: nokia_core.c - removed IRQF_DISABLED macro

From: Anil Belur <[email protected]>

- this patch removes the IRQF_DISABLED macro, as this is
deprecated/noop.

Signed-off-by: Anil Belur <[email protected]>
---
drivers/staging/nokia_h4p/nokia_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/nokia_h4p/nokia_core.c b/drivers/staging/nokia_h4p/nokia_core.c
index 5e19cd6..840cc66 100644
--- a/drivers/staging/nokia_h4p/nokia_core.c
+++ b/drivers/staging/nokia_h4p/nokia_core.c
@@ -1141,7 +1141,7 @@ static int hci_h4p_probe(struct platform_device *pdev)

err = devm_request_irq(&pdev->dev, gpio_to_irq(info->host_wakeup_gpio),
hci_h4p_wakeup_interrupt, IRQF_TRIGGER_FALLING |
- IRQF_TRIGGER_RISING | IRQF_DISABLED,
+ IRQF_TRIGGER_RISING,
"hci_h4p_wkup", info);
if (err < 0) {
dev_err(info->dev, "hci_h4p: unable to get wakeup IRQ %d\n",
--
1.9.1

2014-07-09 11:45:08

by Pavel Machek

Subject: Re: [PATCH 1/2] staging: media: bcm2048: radio-bcm2048.c - removed IRQF_DISABLED macro

On Wed 2014-07-09 11:36:37, Anil Belur wrote:
> From: Anil Belur <[email protected]>
>
> - this patch removes IRQF_DISABLED macro, as this is
> deprecated/noop.
>
> Signed-off-by: Anil Belur <[email protected]>

Acked-by: Pavel Machek <[email protected]>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2014-07-09 11:46:11

by Pavel Machek

Subject: Re: [PATCH 2/2] staging: nokia_h4p: nokia_core.c - removed IRQF_DISABLED macro

On Wed 2014-07-09 11:36:38, Anil Belur wrote:
> From: Anil Belur <[email protected]>
>
> - this patch removes the IRQF_DISABLED macro, as this is
> deprecated/noop.
>
> Signed-off-by: Anil Belur <[email protected]>

Acked-by: Pavel Machek <[email protected]>

I wonder if it would maek sense to do

./include/linux/interrupt.h:#define IRQF_DISABLED 0

to make it extra clear that it is nop now?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2014-07-09 13:22:46

by Anil Belur

Subject: Re: [PATCH 2/2] staging: nokia_h4p: nokia_core.c - removed IRQF_DISABLED macro

On Wednesday 09 July 2014 05:16 PM, Pavel Machek wrote:
> I wonder if it would maek sense to do
> ./include/linux/interrupt.h:#define IRQF_DISABLED 0 to make it extra
> clear that it is nop now? Pavel
yes - it makes sense. there are still a few references to the macro in
the code.

Cheers,
Anil