2014-10-02 16:20:37

by Paul McQuade

Subject: [PATCH] ipc: compat_mq sizeof() instead of sizeof

added a parenthesis for sizeof function

Signed-off-by: Paul McQuade <[email protected]>
---
ipc/compat_mq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ipc/compat_mq.c b/ipc/compat_mq.c
index ef6f91c..27496d9 100644
--- a/ipc/compat_mq.c
+++ b/ipc/compat_mq.c
@@ -25,7 +25,7 @@ struct compat_mq_attr {
static inline int get_compat_mq_attr(struct mq_attr *attr,
const struct compat_mq_attr __user *uattr)
{
- if (!access_ok(VERIFY_READ, uattr, sizeof *uattr))
+ if (!access_ok(VERIFY_READ, uattr, sizeof(*uattr)))
return -EFAULT;

return __get_user(attr->mq_flags, &uattr->mq_flags)
@@ -37,7 +37,7 @@ static inline int get_compat_mq_attr(struct mq_attr *attr,
static inline int put_compat_mq_attr(const struct mq_attr *attr,
struct compat_mq_attr __user *uattr)
{
- if (clear_user(uattr, sizeof *uattr))
+ if (clear_user(uattr, sizeof(*uattr)))
return -EFAULT;

return __put_user(attr->mq_flags, &uattr->mq_flags)
--
1.9.1

2014-10-07 20:07:41

by Rafael Aquini

Subject: Re: [PATCH] ipc: compat_mq sizeof() instead of sizeof

On Thu, Oct 02, 2014 at 05:20:28PM +0100, Paul McQuade wrote:
> added a parenthesis for sizeof function
>

This log message could use some enhancement (just a nit)

Other than that:

Acked-by: Rafael Aquini <[email protected]>

> Signed-off-by: Paul McQuade <[email protected]>
> ---
> ipc/compat_mq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ipc/compat_mq.c b/ipc/compat_mq.c
> index ef6f91c..27496d9 100644
> --- a/ipc/compat_mq.c
> +++ b/ipc/compat_mq.c
> @@ -25,7 +25,7 @@ struct compat_mq_attr {
> static inline int get_compat_mq_attr(struct mq_attr *attr,
> const struct compat_mq_attr __user *uattr)
> {
> - if (!access_ok(VERIFY_READ, uattr, sizeof *uattr))
> + if (!access_ok(VERIFY_READ, uattr, sizeof(*uattr)))
> return -EFAULT;
>
> return __get_user(attr->mq_flags, &uattr->mq_flags)
> @@ -37,7 +37,7 @@ static inline int get_compat_mq_attr(struct mq_attr *attr,
> static inline int put_compat_mq_attr(const struct mq_attr *attr,
> struct compat_mq_attr __user *uattr)
> {
> - if (clear_user(uattr, sizeof *uattr))
> + if (clear_user(uattr, sizeof(*uattr)))
> return -EFAULT;
>
> return __put_user(attr->mq_flags, &uattr->mq_flags)
> --
> 1.9.1
>