2014-10-06 09:25:01

by Chen Hanxiao

Subject: [PATCH] sched: updated comments of CLONE_NEWNS

Signed-off-by: Chen Hanxiao <[email protected]>
---
include/uapi/linux/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
index 34f9d73..db765b4 100644
--- a/include/uapi/linux/sched.h
+++ b/include/uapi/linux/sched.h
@@ -13,7 +13,7 @@
#define CLONE_VFORK 0x00004000 /* set if the parent wants the child to wake it up on mm_release */
#define CLONE_PARENT 0x00008000 /* set if we want to have the same parent as the cloner */
#define CLONE_THREAD 0x00010000 /* Same thread group? */
-#define CLONE_NEWNS 0x00020000 /* New namespace group? */
+#define CLONE_NEWNS 0x00020000 /* New mount namespace group? */
#define CLONE_SYSVSEM 0x00040000 /* share system V SEM_UNDO semantics */
#define CLONE_SETTLS 0x00080000 /* create a new TLS for the child */
#define CLONE_PARENT_SETTID 0x00100000 /* set the TID in the parent */
--
1.9.0

2014-10-06 14:27:50

by Serge Hallyn

Subject: Re: [PATCH] sched: updated comments of CLONE_NEWNS

Quoting Chen Hanxiao ([email protected]):
> Signed-off-by: Chen Hanxiao <[email protected]>

Yeah that'll be helpful to anyone new to these parts. But, why the question mark,
should you drop that too? Either way

Acked-by: Serge E. Hallyn <[email protected]>

> ---
> include/uapi/linux/sched.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
> index 34f9d73..db765b4 100644
> --- a/include/uapi/linux/sched.h
> +++ b/include/uapi/linux/sched.h
> @@ -13,7 +13,7 @@
> #define CLONE_VFORK 0x00004000 /* set if the parent wants the child to wake it up on mm_release */
> #define CLONE_PARENT 0x00008000 /* set if we want to have the same parent as the cloner */
> #define CLONE_THREAD 0x00010000 /* Same thread group? */
> -#define CLONE_NEWNS 0x00020000 /* New namespace group? */
> +#define CLONE_NEWNS 0x00020000 /* New mount namespace group? */
> #define CLONE_SYSVSEM 0x00040000 /* share system V SEM_UNDO semantics */
> #define CLONE_SETTLS 0x00080000 /* create a new TLS for the child */
> #define CLONE_PARENT_SETTID 0x00100000 /* set the TID in the parent */
> --
> 1.9.0
>
> _______________________________________________
> Containers mailing list
> [email protected]
> https://lists.linuxfoundation.org/mailman/listinfo/containers

2014-10-07 08:50:52

by Chen Hanxiao

Subject: RE: [PATCH] sched: updated comments of CLONE_NEWNS

> -----Original Message-----
> From: Serge Hallyn [mailto:[email protected]]
> Sent: Monday, October 06, 2014 10:27 PM
> To: Chen, Hanxiao/?? ????
> Cc: Ingo Molnar; Peter Zijlstra; David Howells;
> [email protected]; [email protected]
> Subject: Re: [PATCH] sched: updated comments of CLONE_NEWNS
>
> Quoting Chen Hanxiao ([email protected]):
> > Signed-off-by: Chen Hanxiao <[email protected]>
>
> Yeah that'll be helpful to anyone new to these parts. But, why the question mark,
> should you drop that too? Either way

Yes, we should drop that question mark.
I'll send a v2 patch soon.

Thanks,
- Chen

>
> Acked-by: Serge E. Hallyn <[email protected]>
>

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?