2014-10-10 18:31:17

by Daniel Kurtz

Subject: [PATCH v3 3/3] ARM: dts: rk3288: add VOP iommu nodes

Add device nodes for the VOP iommus.
Device nodes for other iommus will be added in later patches.

The iommu nodes use the #iommu-cells property as described in:
Documentation/devicetree/bindings/iommu/iommu.txt

Signed-off-by: Daniel Kurtz <[email protected]>
Signed-off-by: Simon Xue <[email protected]>
---
arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 5950b0a..cbc92fa 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -271,6 +271,24 @@
status = "disabled";
};

+ vopb_mmu: iommu@0xff930300 {
+ compatible = "rockchip,iommu";
+ reg = <0xff930300 0x100>;
+ interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "vopb_mmu";
+ #iommu-cells = <0>;
+ status = "disabled";
+ };
+
+ vopl_mmu: iommu@0xff940300 {
+ compatible = "rockchip,iommu";
+ reg = <0xff940300 0x100>;
+ interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "vopl_mmu";
+ #iommu-cells = <0>;
+ status = "disabled";
+ };
+
gic: interrupt-controller@ffc01000 {
compatible = "arm,gic-400";
interrupt-controller;
--
2.1.0.rc2.206.gedb03e5

2014-10-13 22:34:40

by Heiko Stuebner

Subject: Re: [PATCH v3 3/3] ARM: dts: rk3288: add VOP iommu nodes

Hi Daniel,

Am Samstag, 11. Oktober 2014, 02:30:48 schrieb Daniel Kurtz:
> Add device nodes for the VOP iommus.
> Device nodes for other iommus will be added in later patches.
>
> The iommu nodes use the #iommu-cells property as described in:
> Documentation/devicetree/bindings/iommu/iommu.txt
>
> Signed-off-by: Daniel Kurtz <[email protected]>
> Signed-off-by: Simon Xue <[email protected]>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 5950b0a..cbc92fa 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -271,6 +271,24 @@
> status = "disabled";
> };
>
> + vopb_mmu: iommu@0xff930300 {

please use the address without the 0x here ... iommu@ff930300


Thanks
Heiko

> + compatible = "rockchip,iommu";
> + reg = <0xff930300 0x100>;
> + interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "vopb_mmu";
> + #iommu-cells = <0>;
> + status = "disabled";
> + };
> +
> + vopl_mmu: iommu@0xff940300 {
> + compatible = "rockchip,iommu";
> + reg = <0xff940300 0x100>;
> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "vopl_mmu";
> + #iommu-cells = <0>;
> + status = "disabled";
> + };
> +
> gic: interrupt-controller@ffc01000 {
> compatible = "arm,gic-400";
> interrupt-controller;

2014-10-14 07:24:17

by Daniel Kurtz

Subject: Re: [PATCH v3 3/3] ARM: dts: rk3288: add VOP iommu nodes

On Tue, Oct 14, 2014 at 6:33 AM, Heiko Stübner <[email protected]> wrote:
> Hi Daniel,
>
> Am Samstag, 11. Oktober 2014, 02:30:48 schrieb Daniel Kurtz:
>> Add device nodes for the VOP iommus.
>> Device nodes for other iommus will be added in later patches.
>>
>> The iommu nodes use the #iommu-cells property as described in:
>> Documentation/devicetree/bindings/iommu/iommu.txt
>>
>> Signed-off-by: Daniel Kurtz <[email protected]>
>> Signed-off-by: Simon Xue <[email protected]>
>> ---
>> arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index 5950b0a..cbc92fa 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -271,6 +271,24 @@
>> status = "disabled";
>> };
>>
>> + vopb_mmu: iommu@0xff930300 {
>
> please use the address without the 0x here ... iommu@ff930300

I've been doing it wrong for a while and no one else noticed :-). Thanks!
I will resend.

> Thanks
> Heiko
>
>> + compatible = "rockchip,iommu";
>> + reg = <0xff930300 0x100>;
>> + interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "vopb_mmu";
>> + #iommu-cells = <0>;
>> + status = "disabled";
>> + };
>> +
>> + vopl_mmu: iommu@0xff940300 {
>> + compatible = "rockchip,iommu";
>> + reg = <0xff940300 0x100>;
>> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "vopl_mmu";
>> + #iommu-cells = <0>;
>> + status = "disabled";
>> + };
>> +
>> gic: interrupt-controller@ffc01000 {
>> compatible = "arm,gic-400";
>> interrupt-controller;
>