2014-12-05 06:31:28

by Zhang, Jun

Subject: [PATCH] sched/fair: tiny clearup of -1

From: zhang jun <[email protected]>

find_idlest_cpu don't return -1, so clearup it.

Signed-off-by: zhang jun <[email protected]>
Signed-off-by: Chuansheng Liu <[email protected]>
Signed-off-by: Changcheng Liu <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Hillf Danton <[email protected]>
Cc: Vincent Guittot <[email protected]>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index ef2b104..bbf965f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4596,7 +4596,7 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_f
}

new_cpu = find_idlest_cpu(group, p, cpu);
- if (new_cpu == -1 || new_cpu == cpu) {
+ if (new_cpu == cpu) {
/* Now try balancing at a lower domain level of cpu */
sd = sd->child;
continue;
--
1.7.9.5

2014-12-05 21:32:05

by Greg Kroah-Hartman

Subject: Re: [PATCH] sched/fair: tiny clearup of -1

On Fri, Dec 05, 2014 at 02:02:45PM +0800, [email protected] wrote:
> From: zhang jun <[email protected]>
>
> find_idlest_cpu don't return -1, so clearup it.
>
> Signed-off-by: zhang jun <[email protected]>
> Signed-off-by: Chuansheng Liu <[email protected]>
> Signed-off-by: Changcheng Liu <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>

Why me? I don't care about this file...

2014-12-15 16:59:56

by Peter Zijlstra

Subject: Re: [PATCH] sched/fair: tiny clearup of -1

On Fri, Dec 05, 2014 at 02:02:45PM +0800, [email protected] wrote:
> From: zhang jun <[email protected]>
>
> find_idlest_cpu don't return -1, so clearup it.

'clean it up' perhaps?

> Signed-off-by: zhang jun <[email protected]>
> Signed-off-by: Chuansheng Liu <[email protected]>
> Signed-off-by: Changcheng Liu <[email protected]>

Invalid SoB chain.