2015-02-04 12:31:43

by Lad, Prabhakar

Subject: [PATCH] net: ethernet: ti/cpsw-common.c: fix sparse warning

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

cpsw-common.c:23:5: warning: symbol 'cpsw_am33xx_cm_get_macid' was not declared. Should it be static?

Signed-off-by: Lad, Prabhakar <[email protected]>
---
drivers/net/ethernet/ti/cpsw-common.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drivers/net/ethernet/ti/cpsw-common.c
index 763ada1..f595094 100644
--- a/drivers/net/ethernet/ti/cpsw-common.c
+++ b/drivers/net/ethernet/ti/cpsw-common.c
@@ -17,6 +17,8 @@
#include <linux/regmap.h>
#include <linux/mfd/syscon.h>

+#include "cpsw.h"
+
#define AM33XX_CTRL_MAC_LO_REG(offset, id) ((offset) + 0x8 * (id))
#define AM33XX_CTRL_MAC_HI_REG(offset, id) ((offset) + 0x8 * (id) + 0x4)

--
1.9.1

2015-02-05 08:28:04

by David Miller

Subject: Re: [PATCH] net: ethernet: ti/cpsw-common.c: fix sparse warning

From: Lad Prabhakar <[email protected]>
Date: Wed, 4 Feb 2015 12:31:28 +0000

> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warning:
>
> cpsw-common.c:23:5: warning: symbol 'cpsw_am33xx_cm_get_macid' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <[email protected]>

Applied.