2015-02-04 13:03:57

by Lad, Prabhakar

Subject: [PATCH] dma/edma.c: fix sparse warnings

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warnings:

edma.c:537:32: warning: symbol 'edma_prep_dma_memcpy' was not declared. Should it be static?
edma.c:1070:6: warning: symbol 'edma_filter_fn' was not declared. Should it be static?

Signed-off-by: Lad, Prabhakar <[email protected]>
---
Found this issue on linux-next (arm-cortex-a8-gcc version 4.7.3,
sparse version 0.4.5-rc1)and applies on top linux-next.

drivers/dma/edma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index e95fa7d..276157f 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -15,6 +15,7 @@

#include <linux/dmaengine.h>
#include <linux/dma-mapping.h>
+#include <linux/edma.h>
#include <linux/err.h>
#include <linux/init.h>
#include <linux/interrupt.h>
@@ -534,7 +535,7 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
return vchan_tx_prep(&echan->vchan, &edesc->vdesc, tx_flags);
}

-struct dma_async_tx_descriptor *edma_prep_dma_memcpy(
+static struct dma_async_tx_descriptor *edma_prep_dma_memcpy(
struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
size_t len, unsigned long tx_flags)
{
--
1.9.1

2015-02-12 09:35:28

by Vinod Koul

Subject: Re: [PATCH] dma/edma.c: fix sparse warnings

On Wed, Feb 04, 2015 at 01:03:27PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warnings:
>
> edma.c:537:32: warning: symbol 'edma_prep_dma_memcpy' was not declared. Should it be static?
> edma.c:1070:6: warning: symbol 'edma_filter_fn' was not declared. Should it be static?
>
Applied, thanks.

Please ensure you use the right subsystem name and format

--
~Vinod

> Signed-off-by: Lad, Prabhakar <[email protected]>
> ---
> Found this issue on linux-next (arm-cortex-a8-gcc version 4.7.3,
> sparse version 0.4.5-rc1)and applies on top linux-next.
>
> drivers/dma/edma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index e95fa7d..276157f 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -15,6 +15,7 @@
>
> #include <linux/dmaengine.h>
> #include <linux/dma-mapping.h>
> +#include <linux/edma.h>
> #include <linux/err.h>
> #include <linux/init.h>
> #include <linux/interrupt.h>
> @@ -534,7 +535,7 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
> return vchan_tx_prep(&echan->vchan, &edesc->vdesc, tx_flags);
> }
>
> -struct dma_async_tx_descriptor *edma_prep_dma_memcpy(
> +static struct dma_async_tx_descriptor *edma_prep_dma_memcpy(
> struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
> size_t len, unsigned long tx_flags)
> {
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--