2015-02-04 17:30:04

by Lad, Prabhakar

[permalink] [raw]
Subject: [PATCH] sound: soc: codecs/ts3a227e: fix sparse warning

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:
ts3a227e.c:222:5: warning: symbol 'ts3a227e_enable_jack_detect' was not declared. Should it be static?

Signed-off-by: Lad, Prabhakar <[email protected]>
---
Found this issue on linux-next (gcc version 4.8.2,
sparse version 0.4.5-rc1)and applies on top linux-next.

sound/soc/codecs/ts3a227e.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/sound/soc/codecs/ts3a227e.c b/sound/soc/codecs/ts3a227e.c
index 5ecfa31..9fd80ac 100644
--- a/sound/soc/codecs/ts3a227e.c
+++ b/sound/soc/codecs/ts3a227e.c
@@ -20,6 +20,8 @@
#include <sound/jack.h>
#include <sound/soc.h>

+#include "ts3a227e.h"
+
struct ts3a227e {
struct regmap *regmap;
struct snd_soc_jack *jack;
--
1.9.1


2015-02-04 20:09:41

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] sound: soc: codecs/ts3a227e: fix sparse warning

On Wed, Feb 04, 2015 at 05:29:30PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warning:
> ts3a227e.c:222:5: warning: symbol 'ts3a227e_enable_jack_detect' was not declared. Should it be static?

Applied, thanks. Please use subject lines matching the style for the
subsystem.


Attachments:
(No filename) (352.00 B)
signature.asc (473.00 B)
Digital signature
Download all attachments