From: "Lad, Prabhakar" <[email protected]>
this patch fixes following sparse warnings:
uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared. Should it be static?
uvc_video.c:342:5: warning: symbol 'uvcg_video_enable' was not declared. Should it be static?
uvc_video.c:381:5: warning: symbol 'uvcg_video_init' was not declared. Should it be static?
Signed-off-by: Lad, Prabhakar <[email protected]>
---
drivers/usb/gadget/function/uvc_video.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c
index 9cb86bc..50a5e63 100644
--- a/drivers/usb/gadget/function/uvc_video.c
+++ b/drivers/usb/gadget/function/uvc_video.c
@@ -21,6 +21,7 @@
#include "uvc.h"
#include "uvc_queue.h"
+#include "uvc_video.h"
/* --------------------------------------------------------------------------
* Video codecs
--
1.9.1
Hi Prabhakar,
Thank you for the patch.
On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warnings:
>
> uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared.
> Should it be static? uvc_video.c:342:5: warning: symbol 'uvcg_video_enable'
> was not declared. Should it be static? uvc_video.c:381:5: warning: symbol
> 'uvcg_video_init' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <[email protected]>
Acked-by: Laurent Pinchart <[email protected]>
Felipe, could you please take this in your tree ?
> ---
> drivers/usb/gadget/function/uvc_video.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/function/uvc_video.c
> b/drivers/usb/gadget/function/uvc_video.c index 9cb86bc..50a5e63 100644
> --- a/drivers/usb/gadget/function/uvc_video.c
> +++ b/drivers/usb/gadget/function/uvc_video.c
> @@ -21,6 +21,7 @@
>
> #include "uvc.h"
> #include "uvc_queue.h"
> +#include "uvc_video.h"
>
> /*
> --------------------------------------------------------------------------
> * Video codecs
--
Regards,
Laurent Pinchart
On Thu, Feb 05, 2015 at 05:02:46PM +0200, Laurent Pinchart wrote:
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote:
> > From: "Lad, Prabhakar" <[email protected]>
> >
> > this patch fixes following sparse warnings:
> >
> > uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared.
> > Should it be static? uvc_video.c:342:5: warning: symbol 'uvcg_video_enable'
> > was not declared. Should it be static? uvc_video.c:381:5: warning: symbol
> > 'uvcg_video_init' was not declared. Should it be static?
> >
> > Signed-off-by: Lad, Prabhakar <[email protected]>
>
> Acked-by: Laurent Pinchart <[email protected]>
>
> Felipe, could you please take this in your tree ?
my tree is closed for v3.20. I'll pick it up once -rc1 is out
--
balbi
Hi Felipe,
On Thursday 05 February 2015 12:08:09 Felipe Balbi wrote:
> On Thu, Feb 05, 2015 at 05:02:46PM +0200, Laurent Pinchart wrote:
> > Hi Prabhakar,
> >
> > Thank you for the patch.
> >
> > On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote:
> > > From: "Lad, Prabhakar" <[email protected]>
> > >
> > > this patch fixes following sparse warnings:
> > >
> > > uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared.
> > > Should it be static? uvc_video.c:342:5: warning: symbol
> > > 'uvcg_video_enable'
> > > was not declared. Should it be static? uvc_video.c:381:5: warning:
> > > symbol
> > > 'uvcg_video_init' was not declared. Should it be static?
> > >
> > > Signed-off-by: Lad, Prabhakar <[email protected]>
> >
> > Acked-by: Laurent Pinchart <[email protected]>
> >
> > Felipe, could you please take this in your tree ?
>
> my tree is closed for v3.20. I'll pick it up once -rc1 is out
That's good, I was targeting v3.21 too. How do you usually ensure that patches
don't get lost, do you apply them to a n+1 branch straight away (which is what
I was asking in my previous mail), rely on patchwork or some similar tool, or
expect developers to ping you again when -rc1 is out ?
--
Regards,
Laurent Pinchart
On Sun, Feb 08, 2015 at 05:46:38PM +0200, Laurent Pinchart wrote:
> Hi Felipe,
>
> On Thursday 05 February 2015 12:08:09 Felipe Balbi wrote:
> > On Thu, Feb 05, 2015 at 05:02:46PM +0200, Laurent Pinchart wrote:
> > > Hi Prabhakar,
> > >
> > > Thank you for the patch.
> > >
> > > On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote:
> > > > From: "Lad, Prabhakar" <[email protected]>
> > > >
> > > > this patch fixes following sparse warnings:
> > > >
> > > > uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared.
> > > > Should it be static? uvc_video.c:342:5: warning: symbol
> > > > 'uvcg_video_enable'
> > > > was not declared. Should it be static? uvc_video.c:381:5: warning:
> > > > symbol
> > > > 'uvcg_video_init' was not declared. Should it be static?
> > > >
> > > > Signed-off-by: Lad, Prabhakar <[email protected]>
> > >
> > > Acked-by: Laurent Pinchart <[email protected]>
> > >
> > > Felipe, could you please take this in your tree ?
> >
> > my tree is closed for v3.20. I'll pick it up once -rc1 is out
>
> That's good, I was targeting v3.21 too. How do you usually ensure that patches
> don't get lost, do you apply them to a n+1 branch straight away (which is what
> I was asking in my previous mail), rely on patchwork or some similar tool, or
> expect developers to ping you again when -rc1 is out ?
I leave the email unread in another maildir
--
balbi