2015-02-05 15:41:04

by Lad, Prabhakar

Subject: [PATCH] net/macb: fix sparse warning

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static?

Signed-off-by: Lad, Prabhakar <[email protected]>
---
Found this issue on linux-next (gcc version 4.8.2,
sparse version 0.4.5-rc1)and applies on top linux-next.

drivers/net/ethernet/cadence/macb.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
index 31dc080..e6ad68a 100644
--- a/drivers/net/ethernet/cadence/macb.h
+++ b/drivers/net/ethernet/cadence/macb.h
@@ -821,6 +821,7 @@ struct macb {
};

extern const struct ethtool_ops macb_ethtool_ops;
+extern const struct ethtool_ops gem_ethtool_ops;

int macb_mii_init(struct macb *bp);
int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);
--
1.9.1

2015-02-05 16:07:08

by Nicolas Ferre

Subject: Re: [PATCH] net/macb: fix sparse warning

Le 05/02/2015 16:40, Lad Prabhakar a ?crit :
> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warning:
>
> macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static?

Well, actually this function doesn't need to be exported and indeed
should be marked as static.

I'm not against this patch, but removing the export macro and making it
as static should do the trick even better.

Bye,

> Signed-off-by: Lad, Prabhakar <[email protected]>
> ---
> Found this issue on linux-next (gcc version 4.8.2,
> sparse version 0.4.5-rc1)and applies on top linux-next.
>
> drivers/net/ethernet/cadence/macb.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
> index 31dc080..e6ad68a 100644
> --- a/drivers/net/ethernet/cadence/macb.h
> +++ b/drivers/net/ethernet/cadence/macb.h
> @@ -821,6 +821,7 @@ struct macb {
> };
>
> extern const struct ethtool_ops macb_ethtool_ops;
> +extern const struct ethtool_ops gem_ethtool_ops;
>
> int macb_mii_init(struct macb *bp);
> int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);
>


--
Nicolas Ferre

2015-02-05 16:23:13

by Lad, Prabhakar

Subject: Re: [PATCH] net/macb: fix sparse warning

On Thu, Feb 5, 2015 at 4:06 PM, Nicolas Ferre <[email protected]> wrote:
> Le 05/02/2015 16:40, Lad Prabhakar a écrit :
>> From: "Lad, Prabhakar" <[email protected]>
>>
>> this patch fixes following sparse warning:
>>
>> macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static?
>
> Well, actually this function doesn't need to be exported and indeed
> should be marked as static.
>
> I'm not against this patch, but removing the export macro and making it
> as static should do the trick even better.
>
Done!

[1] https://patchwork.kernel.org/patch/5785511/

Cheers,
--Prabhakar Lad

2015-02-05 16:29:32

by Eric Dumazet

Subject: Re: [PATCH] net/macb: fix sparse warning

On Thu, 2015-02-05 at 15:40 +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warning:
>
> macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <[email protected]>
> ---
> Found this issue on linux-next (gcc version 4.8.2,
> sparse version 0.4.5-rc1)and applies on top linux-next.
>
> drivers/net/ethernet/cadence/macb.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
> index 31dc080..e6ad68a 100644
> --- a/drivers/net/ethernet/cadence/macb.h
> +++ b/drivers/net/ethernet/cadence/macb.h
> @@ -821,6 +821,7 @@ struct macb {
> };
>
> extern const struct ethtool_ops macb_ethtool_ops;
> +extern const struct ethtool_ops gem_ethtool_ops;
>
> int macb_mii_init(struct macb *bp);
> int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);

Certainly not.

diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 4f7bd13796b87b873a198ffd0760dedbb9077ed4..ad76b8e35a00e188e39d00f4c5f70d97c3df5363 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -2035,7 +2035,7 @@ const struct ethtool_ops macb_ethtool_ops = {
};
EXPORT_SYMBOL_GPL(macb_ethtool_ops);

-const struct ethtool_ops gem_ethtool_ops = {
+static const struct ethtool_ops gem_ethtool_ops = {
.get_settings = macb_get_settings,
.set_settings = macb_set_settings,
.get_regs_len = macb_get_regs_len,
@@ -2046,7 +2046,6 @@ const struct ethtool_ops gem_ethtool_ops = {
.get_strings = gem_get_ethtool_strings,
.get_sset_count = gem_get_sset_count,
};
-EXPORT_SYMBOL_GPL(gem_ethtool_ops);

int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
{