2015-04-13 09:05:39

by gongzg

Subject: [PATCH] acpica: modify a commit error in file drivers/acpi/acpica/nsxfeval.c

Change "iff" in function acpi_evaluate_object() to "if".

Signed-off-by: Zhaogang Gong <[email protected]>
---
drivers/acpi/acpica/nsxfeval.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/nsxfeval.c b/drivers/acpi/acpica/nsxfeval.c
index b6030a2..9571429 100644
--- a/drivers/acpi/acpica/nsxfeval.c
+++ b/drivers/acpi/acpica/nsxfeval.c
@@ -214,7 +214,7 @@ acpi_evaluate_object(acpi_handle handle,
info->prefix_node = NULL;
} else if (!handle) {
/*
- * A handle is optional iff a fully qualified pathname is specified.
+ * A handle is optional if a fully qualified pathname is specified.
* Since we've already handled fully qualified names above, this is
* an error.
*/
--
1.9.1

2015-04-13 13:13:34

by Rafael J. Wysocki

Subject: Re: [PATCH] acpica: modify a commit error in file drivers/acpi/acpica/nsxfeval.c

On Monday, April 13, 2015 05:05:07 PM Zhaogang Gong wrote:
> Change "iff" in function acpi_evaluate_object() to "if".
>
> Signed-off-by: Zhaogang Gong <[email protected]>
> ---
> drivers/acpi/acpica/nsxfeval.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/nsxfeval.c b/drivers/acpi/acpica/nsxfeval.c
> index b6030a2..9571429 100644
> --- a/drivers/acpi/acpica/nsxfeval.c
> +++ b/drivers/acpi/acpica/nsxfeval.c
> @@ -214,7 +214,7 @@ acpi_evaluate_object(acpi_handle handle,
> info->prefix_node = NULL;
> } else if (!handle) {
> /*
> - * A handle is optional iff a fully qualified pathname is specified.
> + * A handle is optional if a fully qualified pathname is specified.

This is not a mistake.

> * Since we've already handled fully qualified names above, this is
> * an error.
> */
>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

2015-04-13 17:42:51

by Moore, Robert

Subject: RE: [PATCH] acpica: modify a commit error in file drivers/acpi/acpica/nsxfeval.c

Yes, this comes up every now and then.

"iff" means "if and only if" by convention.


> -----Original Message-----
> From: Rafael J. Wysocki [mailto:[email protected]]
> Sent: Monday, April 13, 2015 6:38 AM
> To: Zhaogang Gong
> Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; [email protected]; linux-
> [email protected]; [email protected]; [email protected]
> Subject: Re: [PATCH] acpica: modify a commit error in file
> drivers/acpi/acpica/nsxfeval.c
>
> On Monday, April 13, 2015 05:05:07 PM Zhaogang Gong wrote:
> > Change "iff" in function acpi_evaluate_object() to "if".
> >
> > Signed-off-by: Zhaogang Gong <[email protected]>
> > ---
> > drivers/acpi/acpica/nsxfeval.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/acpica/nsxfeval.c
> > b/drivers/acpi/acpica/nsxfeval.c index b6030a2..9571429 100644
> > --- a/drivers/acpi/acpica/nsxfeval.c
> > +++ b/drivers/acpi/acpica/nsxfeval.c
> > @@ -214,7 +214,7 @@ acpi_evaluate_object(acpi_handle handle,
> > info->prefix_node = NULL;
> > } else if (!handle) {
> > /*
> > - * A handle is optional iff a fully qualified pathname is
> specified.
> > + * A handle is optional if a fully qualified pathname is
> specified.
>
> This is not a mistake.
>
> > * Since we've already handled fully qualified names above,
> this is
> > * an error.
> > */
> >
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?