2015-05-14 00:03:21

by Krzysztof Kozlowski

Subject: [PATCH] drm/exynos: dp: Lower level of EDID read success message

Don't pollute the dmesg with EDID read success message as an error.
Printing as debug should be fine.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 441ef06b8894..30feb7d06624 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -195,7 +195,7 @@ static int exynos_dp_read_edid(struct exynos_dp_device *dp)
}
}

- dev_err(dp->dev, "EDID Read success!\n");
+ dev_dbg(dp->dev, "EDID Read success!\n");
return 0;
}

--
1.9.1

2015-05-18 23:42:35

by Jingoo Han

Subject: Re: [PATCH] drm/exynos: dp: Lower level of EDID read success message

> Don't pollute the dmesg with EDID read success message as an error.
> Printing as debug should be fine.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Right, dev_err() is not right.
Thank you for sending the patch.

Acked-by: Jingoo Han <[email protected]>

Best regards,
Jingoo Han

> ---
> drivers/gpu/drm/exynos/exynos_dp_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index 441ef06b8894..30feb7d06624 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
> @@ -195,7 +195,7 @@ static int exynos_dp_read_edid(struct exynos_dp_device *dp)
> }
> }
>
> - dev_err(dp->dev, "EDID Read success!\n");
> + dev_dbg(dp->dev, "EDID Read success!\n");
> return 0;
> }
>
> --
> 1.9.1