2015-06-02 15:50:04

by Sergei Zviagintsev

Subject: [PATCH] kdbus: kdbus_conn_connect(): use `bus' instead of `conn->ep->bus'

Local `bus' is already set to `conn->ep->bus'. Use it.

Signed-off-by: Sergei Zviagintsev <[email protected]>
---
ipc/kdbus/connection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c
index b00872edbbc9..b9f13749a748 100644
--- a/ipc/kdbus/connection.c
+++ b/ipc/kdbus/connection.c
@@ -432,7 +432,7 @@ static int kdbus_conn_connect(struct kdbus_conn *conn, const char *name)
* directly, and won't cause any notifications.
*/
if (!kdbus_conn_is_monitor(conn)) {
- ret = kdbus_notify_id_change(conn->ep->bus, KDBUS_ITEM_ID_ADD,
+ ret = kdbus_notify_id_change(bus, KDBUS_ITEM_ID_ADD,
conn->id, conn->flags);
if (ret < 0)
goto exit_disconnect;
--
1.8.3.1

2015-06-03 10:33:42

by David Herrmann

Subject: Re: [PATCH] kdbus: kdbus_conn_connect(): use `bus' instead of `conn->ep->bus'

Hi

On Tue, Jun 2, 2015 at 5:48 PM, Sergei Zviagintsev <[email protected]> wrote:
> Local `bus' is already set to `conn->ep->bus'. Use it.
>
> Signed-off-by: Sergei Zviagintsev <[email protected]>
> ---
> ipc/kdbus/connection.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: David Herrmann <[email protected]>

Thanks
David

> diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c
> index b00872edbbc9..b9f13749a748 100644
> --- a/ipc/kdbus/connection.c
> +++ b/ipc/kdbus/connection.c
> @@ -432,7 +432,7 @@ static int kdbus_conn_connect(struct kdbus_conn *conn, const char *name)
> * directly, and won't cause any notifications.
> */
> if (!kdbus_conn_is_monitor(conn)) {
> - ret = kdbus_notify_id_change(conn->ep->bus, KDBUS_ITEM_ID_ADD,
> + ret = kdbus_notify_id_change(bus, KDBUS_ITEM_ID_ADD,
> conn->id, conn->flags);
> if (ret < 0)
> goto exit_disconnect;
> --
> 1.8.3.1
>