2015-06-07 14:43:03

by Nicholas Mc Guire

Subject: [PATCH] [media] gscpa_m5602: use msecs_to_jiffies for conversions

API compliance scanning with coccinelle flagged:
./drivers/media/usb/gspca/m5602/m5602_s5k83a.c:180:9-25:
WARNING: timeout (100) seems HZ dependent

Numeric constants passed to schedule_timeout() make the effective
timeout HZ dependent which makes little sense in a polling loop for
the cameras rotation state.
Fixed up by converting the constant to jiffies with msecs_to_jiffies()

Signed-off-by: Nicholas Mc Guire <[email protected]>
---

Patch was compile tested with i386_defconfig +

Patch is against 4.1-rc6 (localversion-next is -next-20150605)

drivers/media/usb/gspca/m5602/m5602_s5k83a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c
index 7cbc3a0..bf6b215 100644
--- a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c
+++ b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c
@@ -177,7 +177,7 @@ static int rotation_thread_function(void *data)
__s32 vflip, hflip;

set_current_state(TASK_INTERRUPTIBLE);
- while (!schedule_timeout(100)) {
+ while (!schedule_timeout(msecs_to_jiffies(100))) {
if (mutex_lock_interruptible(&sd->gspca_dev.usb_lock))
break;

--
1.7.10.4

2015-06-23 09:54:52

by Hans de Goede

Subject: Re: [PATCH] [media] gscpa_m5602: use msecs_to_jiffies for conversions

Hi,

On 07-06-15 16:34, Nicholas Mc Guire wrote:
> API compliance scanning with coccinelle flagged:
> ./drivers/media/usb/gspca/m5602/m5602_s5k83a.c:180:9-25:
> WARNING: timeout (100) seems HZ dependent
>
> Numeric constants passed to schedule_timeout() make the effective
> timeout HZ dependent which makes little sense in a polling loop for
> the cameras rotation state.
> Fixed up by converting the constant to jiffies with msecs_to_jiffies()
>
> Signed-off-by: Nicholas Mc Guire <[email protected]>

Thanks I've queued this up for merging into 4.3

Regards,

Hans


> ---
>
> Patch was compile tested with i386_defconfig +
>
> Patch is against 4.1-rc6 (localversion-next is -next-20150605)
>
> drivers/media/usb/gspca/m5602/m5602_s5k83a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c
> index 7cbc3a0..bf6b215 100644
> --- a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c
> +++ b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c
> @@ -177,7 +177,7 @@ static int rotation_thread_function(void *data)
> __s32 vflip, hflip;
>
> set_current_state(TASK_INTERRUPTIBLE);
> - while (!schedule_timeout(100)) {
> + while (!schedule_timeout(msecs_to_jiffies(100))) {
> if (mutex_lock_interruptible(&sd->gspca_dev.usb_lock))
> break;
>
>