2015-07-10 18:42:40

by Cristian Ardelean

Subject: [PATCH] cpufreq: integrator: fixed coding style issues

Fixed coding style issues found by checkpatch.pl tool. Changed
space indentation to tab, removed unneccesary braces, removed
space between MODULE macros and parentheses.

REMARKS: failed to 'make' this file with error message
'fatal error: asm/mach-types.h: No such file or directory'.

Signed-off-by: Cristian Ardelean <[email protected]>
---
drivers/cpufreq/integrator-cpufreq.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/drivers/cpufreq/integrator-cpufreq.c b/drivers/cpufreq/integrator-cpufreq.c
index 129e266..2faa421 100644
--- a/drivers/cpufreq/integrator-cpufreq.c
+++ b/drivers/cpufreq/integrator-cpufreq.c
@@ -98,11 +98,10 @@ static int integrator_set_target(struct cpufreq_policy *policy,
/* get current setting */
cm_osc = __raw_readl(cm_base + INTEGRATOR_HDR_OSC_OFFSET);

- if (machine_is_integrator()) {
+ if (machine_is_integrator())
vco.s = (cm_osc >> 8) & 7;
- } else if (machine_is_cintegrator()) {
+ else if (machine_is_cintegrator())
vco.s = 1;
- }
vco.v = cm_osc & 255;
vco.r = 22;
freqs.old = icst_hz(&cclk_params, vco) / 1000;
@@ -163,11 +162,10 @@ static unsigned int integrator_get(unsigned int cpu)
/* detect memory etc. */
cm_osc = __raw_readl(cm_base + INTEGRATOR_HDR_OSC_OFFSET);

- if (machine_is_integrator()) {
+ if (machine_is_integrator())
vco.s = (cm_osc >> 8) & 7;
- } else {
+ else
vco.s = 1;
- }
vco.v = cm_osc & 255;
vco.r = 22;

@@ -203,7 +201,7 @@ static int __init integrator_cpufreq_probe(struct platform_device *pdev)
struct resource *res;

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
+ if (!res)
return -ENODEV;

cm_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
@@ -234,6 +232,6 @@ static struct platform_driver integrator_cpufreq_driver = {
module_platform_driver_probe(integrator_cpufreq_driver,
integrator_cpufreq_probe);

-MODULE_AUTHOR ("Russell M. King");
-MODULE_DESCRIPTION ("cpufreq driver for ARM Integrator CPUs");
-MODULE_LICENSE ("GPL");
+MODULE_AUTHOR("Russell M. King");
+MODULE_DESCRIPTION("cpufreq driver for ARM Integrator CPUs");
+MODULE_LICENSE("GPL");
--
1.7.9.5

2015-07-13 02:31:53

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: integrator: fixed coding style issues

On 10-07-15, 14:42, Cristian Ardelean wrote:
> Fixed coding style issues found by checkpatch.pl tool. Changed
> space indentation to tab, removed unneccesary braces, removed
> space between MODULE macros and parentheses.
>
> REMARKS: failed to 'make' this file with error message
> 'fatal error: asm/mach-types.h: No such file or directory'.
>
> Signed-off-by: Cristian Ardelean <[email protected]>
> ---
> drivers/cpufreq/integrator-cpufreq.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2015-07-16 00:06:33

by Rafael J. Wysocki

Subject: Re: [PATCH] cpufreq: integrator: fixed coding style issues

On Monday, July 13, 2015 08:01:46 AM Viresh Kumar wrote:
> On 10-07-15, 14:42, Cristian Ardelean wrote:
> > Fixed coding style issues found by checkpatch.pl tool. Changed
> > space indentation to tab, removed unneccesary braces, removed
> > space between MODULE macros and parentheses.
> >
> > REMARKS: failed to 'make' this file with error message
> > 'fatal error: asm/mach-types.h: No such file or directory'.
> >
> > Signed-off-by: Cristian Ardelean <[email protected]>
> > ---
> > drivers/cpufreq/integrator-cpufreq.c | 18 ++++++++----------
> > 1 file changed, 8 insertions(+), 10 deletions(-)
>
> Acked-by: Viresh Kumar <[email protected]>

Patch queued up for 4.3, thanks!


--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.