According to the discussion on the mailing list, this version adds a new patch
to force select FRAME_POINTER for ARM64.
Change v2 --> v1:
1. Adds a new patch to force select FRAME_POINTER
2. Notes that this change adds a dependency on DEBUG_KERNEL for building with
frame pointers
Yang Shi (2):
arm64: remove redundant FRAME_POINTER kconfig option
arm64: force to select FRAME_POINTER
arch/arm64/Kconfig | 1 +
arch/arm64/Kconfig.debug | 4 ----
2 files changed, 1 insertion(+), 4 deletions(-)
FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine
it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory
is never used.
This adds a dependency on DEBUG_KERNEL for building with frame pointers.
Signed-off-by: Yang Shi <[email protected]>
---
arch/arm64/Kconfig.debug | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm64/Kconfig.debug b/arch/arm64/Kconfig.debug
index d6285ef..915dea7 100644
--- a/arch/arm64/Kconfig.debug
+++ b/arch/arm64/Kconfig.debug
@@ -2,10 +2,6 @@ menu "Kernel hacking"
source "lib/Kconfig.debug"
-config FRAME_POINTER
- bool
- default y
-
config ARM64_PTDUMP
bool "Export kernel pagetable layout to userspace via debugfs"
depends on DEBUG_KERNEL
--
2.0.2
ARM64 depends on frame pointer to get correct stack backtrace and need
FRAME_POINTER kconfig option enabled all the time.
However, currect implementation makes it could be disabled, so force it
to be selected by ARM64.
Signed-off-by: Yang Shi <[email protected]>
---
arch/arm64/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 440d906..b554da2 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -27,6 +27,7 @@ config ARM64
select CPU_PM if (SUSPEND || CPU_IDLE)
select DCACHE_WORD_ACCESS
select EDAC_SUPPORT
+ select FRAME_POINTER
select GENERIC_ALLOCATOR
select GENERIC_CLOCKEVENTS
select GENERIC_CLOCKEVENTS_BROADCAST
--
2.0.2
On Mon, Nov 09, 2015 at 09:43:55AM -0800, Yang Shi wrote:
> According to the discussion on the mailing list, this version adds a new patch
> to force select FRAME_POINTER for ARM64.
>
> Change v2 --> v1:
> 1. Adds a new patch to force select FRAME_POINTER
> 2. Notes that this change adds a dependency on DEBUG_KERNEL for building with
> frame pointers
>
>
> Yang Shi (2):
> arm64: remove redundant FRAME_POINTER kconfig option
> arm64: force to select FRAME_POINTER
Do you really need two patches for this?
--
Catalin
On 11/9/2015 10:14 AM, Catalin Marinas wrote:
> On Mon, Nov 09, 2015 at 09:43:55AM -0800, Yang Shi wrote:
>> According to the discussion on the mailing list, this version adds a new patch
>> to force select FRAME_POINTER for ARM64.
>>
>> Change v2 --> v1:
>> 1. Adds a new patch to force select FRAME_POINTER
>> 2. Notes that this change adds a dependency on DEBUG_KERNEL for building with
>> frame pointers
>>
>>
>> Yang Shi (2):
>> arm64: remove redundant FRAME_POINTER kconfig option
>> arm64: force to select FRAME_POINTER
>
> Do you really need two patches for this?
I just thought it may be clearer in this way. If nobody thinks it is
necessary, I definitely could merge them into one.
Thanks,
Yang
>
On Mon, Nov 09, 2015 at 10:16:32AM -0800, Shi, Yang wrote:
> On 11/9/2015 10:14 AM, Catalin Marinas wrote:
> >On Mon, Nov 09, 2015 at 09:43:55AM -0800, Yang Shi wrote:
> >>According to the discussion on the mailing list, this version adds a new patch
> >>to force select FRAME_POINTER for ARM64.
> >>
> >>Change v2 --> v1:
> >>1. Adds a new patch to force select FRAME_POINTER
> >>2. Notes that this change adds a dependency on DEBUG_KERNEL for building with
> >>frame pointers
> >>
> >>
> >>Yang Shi (2):
> >> arm64: remove redundant FRAME_POINTER kconfig option
> >> arm64: force to select FRAME_POINTER
> >
> >Do you really need two patches for this?
>
> I just thought it may be clearer in this way. If nobody thinks it is
> necessary, I definitely could merge them into one.
Please merge them into one.
--
Catalin