On Wed, 2015-09-16 at 07:33 +0200, Willy Tarreau wrote:
> Hi Olga,
>
> On Tue, Sep 15, 2015 at 02:36:06PM +0000, Kornievskaia, Olga wrote:
> >
> > Hi Willy,
> >
> > After checking with the list, I believe the course of action will be to
> > correct the patch with the patch below instead of reverting it.
>
> OK but as far as I can tell, mainline is still not fixed regarding this
> issue. I can't introduce in a stable branch a fix which is not yet in
> mainline. Thus I'll simply remove the patch from this series and will
> merge both patches in a future series once your fix reaches mainline.
>
> Note that I picked this fix from 3.2 (commit ef8500b18fc4bb) so my
> understanding is that this patch needs to be reverted from 3.2 as well
> for the time being ?
>
> Thanks very much for the detailed investigations!
The second patch is now in mainline as commit
a41cbe86df3afbc82311a1640e20858c0cd7e065, and appears to be needed on
all stable branches since they all got the previous incorrect patch.
Ben.
--
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
- Albert Einstein
On Sun, Nov 15, 2015 at 12:53:21AM +0000, Ben Hutchings wrote:
> On Wed, 2015-09-16 at 07:33 +0200, Willy Tarreau wrote:
> > Hi Olga,
> >
> > On Tue, Sep 15, 2015 at 02:36:06PM +0000, Kornievskaia, Olga wrote:
> > >
> > > Hi Willy,
> > >
> > > After checking with the list, I believe the course of action will be to
> > > correct the patch with the patch below instead of reverting it.
> >
> > OK but as far as I can tell, mainline is still not fixed regarding this
> > issue. I can't introduce in a stable branch a fix which is not yet in
> > mainline. Thus I'll simply remove the patch from this series and will
> > merge both patches in a future series once your fix reaches mainline.
> >
> > Note that I picked this fix from 3.2 (commit ef8500b18fc4bb) so my
> > understanding is that this patch needs to be reverted from 3.2 as well
> > for the time being ?
> >
> > Thanks very much for the detailed investigations!
>
> The second patch is now in mainline as commit
> a41cbe86df3afbc82311a1640e20858c0cd7e065, and appears to be needed on
> all stable branches since they all got the previous incorrect patch.
Now queued, thanks Ben!
Willy
On Sun, Nov 15, 2015 at 12:53:21AM +0000, Ben Hutchings wrote:
> On Wed, 2015-09-16 at 07:33 +0200, Willy Tarreau wrote:
> > Hi Olga,
> >
> > On Tue, Sep 15, 2015 at 02:36:06PM +0000, Kornievskaia, Olga wrote:
> > >
> > > Hi Willy,
> > >
> > > After checking with the list, I believe the course of action will be to
> > > correct the patch with the patch below instead of reverting it.
> >
> > OK but as far as I can tell, mainline is still not fixed regarding this
> > issue. I can't introduce in a stable branch a fix which is not yet in
> > mainline. Thus I'll simply remove the patch from this series and will
> > merge both patches in a future series once your fix reaches mainline.
> >
> > Note that I picked this fix from 3.2 (commit ef8500b18fc4bb) so my
> > understanding is that this patch needs to be reverted from 3.2 as well
> > for the time being ?
> >
> > Thanks very much for the detailed investigations!
>
> The second patch is now in mainline as commit
> a41cbe86df3afbc82311a1640e20858c0cd7e065, and appears to be needed on
> all stable branches since they all got the previous incorrect patch.
>
Thanks, queuing it for the 3.16 kernel.
Cheers,
--
Lu?s