2015-11-30 19:41:24

by Ricardo Ribalda Delgado

Subject: [PATCH v2] spi/nor: Fix error message with unrecognized JEDEC

The error message was:

m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0

The new error message:

m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00

Signed-off-by: Ricardo Ribalda Delgado <[email protected]>
---

v2: Changes by Marek Vasut

Use %02 instead of %.2

drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index b7c038c75684..f8a9b77aac76 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct spi_nor *nor)
return &spi_nor_ids[tmp];
}
}
- dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
+ dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %02x, %02x\n",
id[0], id[1], id[2]);
return ERR_PTR(-ENODEV);
}
--
2.6.2

2015-11-30 22:37:45

by Rafał Miłecki

Subject: Re: [PATCH v2] spi/nor: Fix error message with unrecognized JEDEC

On 30 November 2015 at 20:41, Ricardo Ribalda Delgado
<[email protected]> wrote:
> The error message was:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0
>
> The new error message:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
>
> Signed-off-by: Ricardo Ribalda Delgado <[email protected]>
> ---
>
> v2: Changes by Marek Vasut
>
> Use %02 instead of %.2
>
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index b7c038c75684..f8a9b77aac76 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct spi_nor *nor)
> return &spi_nor_ids[tmp];
> }
> }
> - dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
> + dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %02x, %02x\n",

Looks fine :)

--
Rafał

2015-12-01 18:40:15

by Brian Norris

Subject: Re: [PATCH v2] spi/nor: Fix error message with unrecognized JEDEC

On Mon, Nov 30, 2015 at 08:41:17PM +0100, Ricardo Ribalda Delgado wrote:
> The error message was:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0
>
> The new error message:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
>
> Signed-off-by: Ricardo Ribalda Delgado <[email protected]>
> ---
>
> v2: Changes by Marek Vasut

Pushed to l2-mtd.git