2015-12-05 19:51:01

by Diego Viola

[permalink] [raw]
Subject: [PATCH] README: cosmetic fixes

Signed-off-by: Diego Viola <[email protected]>
---
README | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/README b/README
index f4756ee..afc4f0d 100644
--- a/README
+++ b/README
@@ -59,7 +59,7 @@ DOCUMENTATION:
INSTALLING the kernel source:

- If you install the full sources, put the kernel tarball in a
- directory where you have permissions (eg. your home directory) and
+ directory where you have permissions (e.g. your home directory) and
unpack it:

xz -cd linux-4.X.tar.xz | tar xvf -
@@ -125,7 +125,7 @@ BUILD directory for the kernel:

When compiling the kernel, all output files will per default be
stored together with the kernel source code.
- Using the option "make O=output/dir" allow you to specify an alternate
+ Using the option "make O=output/dir" allows you to specify an alternate
place for the output files (including .config).
Example:

@@ -159,9 +159,9 @@ CONFIGURING the kernel:

"make nconfig" Enhanced text based color menus.

- "make xconfig" X windows (Qt) based configuration tool.
+ "make xconfig" Qt based configuration tool.

- "make gconfig" X windows (GTK+) based configuration tool.
+ "make gconfig" GTK+ based configuration tool.

"make oldconfig" Default all questions based on the contents of
your existing ./.config file and asking about
@@ -268,8 +268,8 @@ COMPILING the kernel:
Normally, the kernel build system runs in a fairly quiet mode (but not
totally silent). However, sometimes you or other kernel developers need
to see compile, link, or other commands exactly as they are executed.
- For this, use "verbose" build mode. This is done by inserting
- "V=1" in the "make" command. E.g.:
+ For this, use "verbose" build mode. This is done by passing
+ "V=1" to the "make" command, e.g.

make V=1 all

@@ -300,7 +300,7 @@ COMPILING the kernel:
kernel image file is usually /vmlinuz, /boot/vmlinuz, /bzImage or
/boot/bzImage. To use the new kernel, save a copy of the old image
and copy the new image over the old one. Then, you MUST RERUN LILO
- to update the loading map!! If you don't, you won't be able to boot
+ to update the loading map! If you don't, you won't be able to boot
the new kernel image.

Reinstalling LILO is usually a matter of running /sbin/lilo.
--
2.6.3


2015-12-10 18:34:28

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] README: cosmetic fixes

I've applied this to the docs tree. I'd sure rather see an effort to
update this file instead of tweaking it, though. For example:

> @@ -300,7 +300,7 @@ COMPILING the kernel:
> kernel image file is usually /vmlinuz, /boot/vmlinuz, /bzImage or
> /boot/bzImage. To use the new kernel, save a copy of the old image
> and copy the new image over the old one. Then, you MUST RERUN LILO
> - to update the loading map!! If you don't, you won't be able to boot
> + to update the loading map! If you don't, you won't be able to boot
> the new kernel image.
>
> Reinstalling LILO is usually a matter of running /sbin/lilo.

I somehow suspect that very few of us actually MUST RERUN LILO in 2015...

Thanks,

jon

2015-12-11 03:06:57

by Diego Viola

[permalink] [raw]
Subject: Re: [PATCH] README: cosmetic fixes

Hi Jonathan,

Thanks for applying my patch. I actually have to admit that before
sending my patch I actually thought about the same thing regarding
LILO being in the README.

I asked on IRC and a few places about this because I don't feel like
removing anything before asking the community first. LILO still seems
to be alive as a project but not many people use it anymore, as you
have mentioned.

I agree the README feels outdated in many ways, I would be happy to do
some clean up, but I also want some input from the community on what
should stay and what should go. Should I send a new email to discuss
this?

Also, see this:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/x86/boot/install.sh

This script calls /sbin/lilo if it's available during the make
install, so I don't think we can just remove LILO from the README if
it's still being used for the make install?

If we end up removing LILO from the README, should we remove it from
the Makefile as well?

This Makefile hasn't been updated in a few years I think.

Thanks,

Diego

On Thu, Dec 10, 2015 at 4:34 PM, Jonathan Corbet <[email protected]> wrote:
> I've applied this to the docs tree. I'd sure rather see an effort to
> update this file instead of tweaking it, though. For example:
>
>> @@ -300,7 +300,7 @@ COMPILING the kernel:
>> kernel image file is usually /vmlinuz, /boot/vmlinuz, /bzImage or
>> /boot/bzImage. To use the new kernel, save a copy of the old image
>> and copy the new image over the old one. Then, you MUST RERUN LILO
>> - to update the loading map!! If you don't, you won't be able to boot
>> + to update the loading map! If you don't, you won't be able to boot
>> the new kernel image.
>>
>> Reinstalling LILO is usually a matter of running /sbin/lilo.
>
> I somehow suspect that very few of us actually MUST RERUN LILO in 2015...
>
> Thanks,
>
> jon