2015-12-11 11:27:28

by Måns Rullgård

Subject: [PATCH] ASoC: wm8974: set cache type for regmap

Attempting to use this codec driver triggers a BUG() in regcache_sync()
since no cache type is set. The register map of this device is fairly
small and has few holes so a flat cache is suitable.

Signed-off-by: Mans Rullgard <[email protected]>
---
sound/soc/codecs/wm8974.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/wm8974.c b/sound/soc/codecs/wm8974.c
index 45ba828..c284c7b 100644
--- a/sound/soc/codecs/wm8974.c
+++ b/sound/soc/codecs/wm8974.c
@@ -574,6 +574,7 @@ static const struct regmap_config wm8974_regmap = {
.max_register = WM8974_MONOMIX,
.reg_defaults = wm8974_reg_defaults,
.num_reg_defaults = ARRAY_SIZE(wm8974_reg_defaults),
+ .cache_type = REGCACHE_FLAT,
};

static int wm8974_probe(struct snd_soc_codec *codec)
--
2.6.3

2015-12-11 12:54:42

by Charles Keepax

Subject: Re: [PATCH] ASoC: wm8974: set cache type for regmap

On Fri, Dec 11, 2015 at 11:27:08AM +0000, Mans Rullgard wrote:
> Attempting to use this codec driver triggers a BUG() in regcache_sync()
> since no cache type is set. The register map of this device is fairly
> small and has few holes so a flat cache is suitable.
>
> Signed-off-by: Mans Rullgard <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles