2024-06-04 16:47:36

by Julien Panis

[permalink] [raw]
Subject: [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Return error in case of invalid efuse data

This patch prevents from registering thermal entries and letting the
driver misbehave if efuse data is invalid. A device is not properly
calibrated if the golden temperature is zero.

Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
Signed-off-by: Julien Panis <[email protected]>
---
Guard against invalid calibration data, following this discussion:
https://lore.kernel.org/all/[email protected]/
---
Changes in v2:
- Add Fixes tag.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
drivers/thermal/mediatek/lvts_thermal.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index 0bb3a495b56e..185d5a32711f 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -769,7 +769,11 @@ static int lvts_golden_temp_init(struct device *dev, u8 *calib,
*/
gt = (((u32 *)calib)[0] >> lvts_data->gt_calib_bit_offset) & 0xff;

- if (gt && gt < LVTS_GOLDEN_TEMP_MAX)
+ /* A zero value for gt means that device has invalid efuse data */
+ if (!gt)
+ return -ENODATA;
+
+ if (gt < LVTS_GOLDEN_TEMP_MAX)
golden_temp = gt;

golden_temp_offset = golden_temp * 500 + lvts_data->temp_offset;

---
base-commit: 632483ea8004edfadd035de36e1ab2c7c4f53158
change-id: 20240603-mtk-thermal-calib-check-ba2ec24a1c32

Best regards,
--
Julien Panis <[email protected]>



2024-06-04 17:00:27

by Nicolas Pitre

[permalink] [raw]
Subject: Re: [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Return error in case of invalid efuse data

On Tue, 4 Jun 2024, Julien Panis wrote:

> This patch prevents from registering thermal entries and letting the
> driver misbehave if efuse data is invalid. A device is not properly
> calibrated if the golden temperature is zero.
>
> Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
> Signed-off-by: Julien Panis <[email protected]>

Reviewed-by: Nicolas Pitre <[email protected]>

> ---
> Guard against invalid calibration data, following this discussion:
> https://lore.kernel.org/all/[email protected]/
> ---
> Changes in v2:
> - Add Fixes tag.
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 0bb3a495b56e..185d5a32711f 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -769,7 +769,11 @@ static int lvts_golden_temp_init(struct device *dev, u8 *calib,
> */
> gt = (((u32 *)calib)[0] >> lvts_data->gt_calib_bit_offset) & 0xff;
>
> - if (gt && gt < LVTS_GOLDEN_TEMP_MAX)
> + /* A zero value for gt means that device has invalid efuse data */
> + if (!gt)
> + return -ENODATA;
> +
> + if (gt < LVTS_GOLDEN_TEMP_MAX)
> golden_temp = gt;
>
> golden_temp_offset = golden_temp * 500 + lvts_data->temp_offset;
>
> ---
> base-commit: 632483ea8004edfadd035de36e1ab2c7c4f53158
> change-id: 20240603-mtk-thermal-calib-check-ba2ec24a1c32
>
> Best regards,
> --
> Julien Panis <[email protected]>
>
>

2024-06-04 17:47:29

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Return error in case of invalid efuse data

On 04/06/2024 18:46, Julien Panis wrote:
> This patch prevents from registering thermal entries and letting the
> driver misbehave if efuse data is invalid. A device is not properly
> calibrated if the golden temperature is zero.
>
> Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
> Signed-off-by: Julien Panis <[email protected]>
> ---
> Guard against invalid calibration data, following this discussion:
> https://lore.kernel.org/all/[email protected]/
> ---

Applied for v6.10-rc3

Thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


Subject: Re: [PATCH v2] thermal/drivers/mediatek/lvts_thermal: Return error in case of invalid efuse data

Il 04/06/24 18:46, Julien Panis ha scritto:
> This patch prevents from registering thermal entries and letting the
> driver misbehave if efuse data is invalid. A device is not properly
> calibrated if the golden temperature is zero.
>
> Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
> Signed-off-by: Julien Panis <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>