2016-10-29 08:14:00

by Ming Lei

[permalink] [raw]
Subject: [PATCH 16/60] block: pktcdvd: comment on direct access to bvec table

Signed-off-by: Ming Lei <[email protected]>
---
drivers/block/pktcdvd.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 90fa4ac149db..817d2cc17d01 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -1298,6 +1298,11 @@ static int pkt_handle_queue(struct pktcdvd_device *pd)
static void pkt_start_write(struct pktcdvd_device *pd, struct packet_data *pkt)
{
int f;
+
+ /*
+ * Need to fix this usage for supporting multipage bvecs,
+ * because the table can be changed in pkt_make_local_copy().
+ */
struct bio_vec *bvec = pkt->w_bio->bi_io_vec;

bio_reset(pkt->w_bio);
--
2.7.4


2016-10-31 15:33:26

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH 16/60] block: pktcdvd: comment on direct access to bvec table

Please pick up my "pktcdvd: don't scribble over the bvec array"
patch instead of the pktcdvd patches in this series.

2016-10-31 23:09:03

by Ming Lei

[permalink] [raw]
Subject: Re: [PATCH 16/60] block: pktcdvd: comment on direct access to bvec table

On Mon, Oct 31, 2016 at 11:33 PM, Christoph Hellwig <[email protected]> wrote:
> Please pick up my "pktcdvd: don't scribble over the bvec array"
> patch instead of the pktcdvd patches in this series.

OK.

Thanks,
Ming Lei