2016-10-29 16:10:37

by Wei Yongjun

Subject: [PATCH -next] brd: make symbol rd_size static

From: Wei Yongjun <[email protected]>

Fixes the following sparse warning:

drivers/block/brd.c:411:15: warning:
symbol 'rd_size' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/block/brd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index ad793f3..d1edf42 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -408,7 +408,7 @@ static int rd_nr = CONFIG_BLK_DEV_RAM_COUNT;
module_param(rd_nr, int, S_IRUGO);
MODULE_PARM_DESC(rd_nr, "Maximum number of brd devices");

-unsigned long rd_size = CONFIG_BLK_DEV_RAM_SIZE;
+static unsigned long rd_size = CONFIG_BLK_DEV_RAM_SIZE;
module_param(rd_size, ulong, S_IRUGO);
MODULE_PARM_DESC(rd_size, "Size of each RAM disk in kbytes.");

2016-10-30 03:57:44

by Jens Axboe

Subject: Re: [PATCH -next] brd: make symbol rd_size static

On 10/29/2016 10:10 AM, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fixes the following sparse warning:
>
> drivers/block/brd.c:411:15: warning:
> symbol 'rd_size' was not declared. Should it be static?

We just tried this, it's used in arm:

arch/arm/kernel/atags_parse.c

static int __init parse_tag_ramdisk(const struct tag *tag)
{
extern int rd_size, rd_image_start, rd_prompt, rd_doload;
[...]

--
Jens Axboe

2016-10-30 09:47:03

by Jan Kara

Subject: Re: [PATCH -next] brd: make symbol rd_size static

On Sat 29-10-16 16:10:27, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fixes the following sparse warning:
>
> drivers/block/brd.c:411:15: warning:
> symbol 'rd_size' was not declared. Should it be static?

It should not. It is used in arch/arm/.

Honza
--
Jan Kara <[email protected]>
SUSE Labs, CR

2016-10-30 12:40:35

by Wei Yongjun

Subject: Re: [PATCH -next] brd: make symbol rd_size static

On 10/30/2016 11:57 AM, Jens Axboe wrote:
> On 10/29/2016 10:10 AM, Wei Yongjun wrote:
>> From: Wei Yongjun <[email protected]>
>>
>> Fixes the following sparse warning:
>>
>> drivers/block/brd.c:411:15: warning:
>> symbol 'rd_size' was not declared. Should it be static?
>
> We just tried this, it's used in arm:
>
> arch/arm/kernel/atags_parse.c
>
> static int __init parse_tag_ramdisk(const struct tag *tag)
> {
> extern int rd_size, rd_image_start, rd_prompt, rd_doload;
> [...]
>
Oh, yeah, got it.

Thank you very much.

Regards,
Yongjun Wei