2017-07-04 06:06:11

by Jaya Durga

Subject: [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.

Signed-off-by: Jaya Durga <[email protected]>
---
drivers/staging/rtl8712/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 8836b31..e698f6e 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -93,7 +93,7 @@
*/
static int wifi_test;

-module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), 0644);
module_param(wifi_test, int, 0644);
module_param(initmac, charp, 0644);
module_param(video_mode, int, 0644);
--
1.9.1

2017-07-11 17:09:08

by Greg Kroah-Hartman

Subject: Re: [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation

On Tue, Jul 04, 2017 at 11:31:15AM +0530, Jaya Durga wrote:
> Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
>
> Signed-off-by: Jaya Durga <[email protected]>
> ---
> drivers/staging/rtl8712/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Did something change from the previous version of this patch? If so,
what?

And again, where are the rest of the patches in this series?

thanks,

greg k-h