2017-07-04 10:46:39

by Jaya Durga

Subject: [PATCH 7/7] Staging: rtl8712 : rtl871x_io.c:fix coding style of kmalloc usage

CHECK: multiple assignments should be avoided
CHECK: Prefer kmalloc(sizeof(*pintf_hdl->pintfpriv)...)
over kmalloc(sizeof(struct intf_priv)...)

Signed-off-by: Jaya Durga <[email protected]>
---
drivers/staging/rtl8712/rtl871x_io.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl871x_io.c b/drivers/staging/rtl8712/rtl871x_io.c
index 3a10940..b8b47c4 100644
--- a/drivers/staging/rtl8712/rtl871x_io.c
+++ b/drivers/staging/rtl8712/rtl871x_io.c
@@ -60,8 +60,9 @@ static uint _init_intf_hdl(struct _adapter *padapter,
set_intf_funs = &(r8712_usb_set_intf_funs);
set_intf_ops = &r8712_usb_set_intf_ops;
init_intf_priv = &r8712_usb_init_intf_priv;
- pintf_priv = pintf_hdl->pintfpriv = kmalloc(sizeof(struct intf_priv),
+ pintf_hdl->pintfpriv = kmalloc(sizeof(*pintf_hdl->pintfpriv),
GFP_ATOMIC);
+ pintf_priv = pintf_hdl->pintfpriv;
if (pintf_priv == NULL)
goto _init_intf_hdl_fail;
pintf_hdl->adapter = (u8 *)padapter;
--
1.9.1

2017-07-11 17:09:38

by Greg Kroah-Hartman

Subject: Re: [PATCH 7/7] Staging: rtl8712 : rtl871x_io.c:fix coding style of kmalloc usage

On Tue, Jul 04, 2017 at 04:11:31PM +0530, Jaya Durga wrote:
> CHECK: multiple assignments should be avoided
> CHECK: Prefer kmalloc(sizeof(*pintf_hdl->pintfpriv)...)
> over kmalloc(sizeof(struct intf_priv)...)
>
> Signed-off-by: Jaya Durga <[email protected]>
> ---
> drivers/staging/rtl8712/rtl871x_io.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Where are the other 6 patches in this series? I can't apply just one of
them :(