The newly added hexint helper is more convenient for bitmasks.
Before:
$ more /sys/module/amdgpu/parameters/ppfeaturemask
4294950911
After:
$ more /sys/module/amdgpu/parameters/ppfeaturemask
0xffffbfff
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Paul Menzel <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 126e74758a34..5c4263335cba 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -391,12 +391,12 @@ MODULE_PARM_DESC(sched_hw_submission, "the max number of HW submissions (default
module_param_named(sched_hw_submission, amdgpu_sched_hw_submission, int, 0444);
/**
- * DOC: ppfeaturemask (uint)
+ * DOC: ppfeaturemask (hexint)
* Override power features enabled. See enum PP_FEATURE_MASK in drivers/gpu/drm/amd/include/amd_shared.h.
* The default is the current set of stable power features.
*/
MODULE_PARM_DESC(ppfeaturemask, "all power features enabled (default))");
-module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, uint, 0444);
+module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, hexint, 0444);
/**
* DOC: forcelongtraining (uint)
--
2.26.2
Am 03.07.20 um 16:29 schrieb Paul Menzel:
> The newly added hexint helper is more convenient for bitmasks.
>
> Before:
>
> $ more /sys/module/amdgpu/parameters/ppfeaturemask
> 4294950911
>
> After:
>
> $ more /sys/module/amdgpu/parameters/ppfeaturemask
> 0xffffbfff
>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Paul Menzel <[email protected]>
Reviewed-by: Christian König <[email protected]> for this one.
Feel free to add my Acked-by to the other two, but I'm not familiar
enough with the code to review those.
Regards,
Christian.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 126e74758a34..5c4263335cba 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -391,12 +391,12 @@ MODULE_PARM_DESC(sched_hw_submission, "the max number of HW submissions (default
> module_param_named(sched_hw_submission, amdgpu_sched_hw_submission, int, 0444);
>
> /**
> - * DOC: ppfeaturemask (uint)
> + * DOC: ppfeaturemask (hexint)
> * Override power features enabled. See enum PP_FEATURE_MASK in drivers/gpu/drm/amd/include/amd_shared.h.
> * The default is the current set of stable power features.
> */
> MODULE_PARM_DESC(ppfeaturemask, "all power features enabled (default))");
> -module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, uint, 0444);
> +module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, hexint, 0444);
>
> /**
> * DOC: forcelongtraining (uint)
Dear Linus, dear Christian,
Am 03.07.20 um 17:29 schrieb Christian König:
> Am 03.07.20 um 16:29 schrieb Paul Menzel:
>> The newly added hexint helper is more convenient for bitmasks.
>>
>> Before:
>>
>> $ more /sys/module/amdgpu/parameters/ppfeaturemask
>> 4294950911
>>
>> After:
>>
>> $ more /sys/module/amdgpu/parameters/ppfeaturemask
>> 0xffffbfff
>>
>> Cc: [email protected]
>> Cc: [email protected]
>> Signed-off-by: Paul Menzel <[email protected]>
>
> Reviewed-by: Christian König <[email protected]> for this one.
>
> Feel free to add my Acked-by to the other two, but I'm not familiar
> enough with the code to review those.
Thank you. Sorry for being ignorant, but what is the way forward?
Kind regards,
Paul
Am 23.07.20 um 15:44 schrieb Paul Menzel:
> Dear Linus, dear Christian,
>
>
> Am 03.07.20 um 17:29 schrieb Christian König:
>> Am 03.07.20 um 16:29 schrieb Paul Menzel:
>>> The newly added hexint helper is more convenient for bitmasks.
>>>
>>> Before:
>>>
>>> $ more /sys/module/amdgpu/parameters/ppfeaturemask
>>> 4294950911
>>>
>>> After:
>>>
>>> $ more /sys/module/amdgpu/parameters/ppfeaturemask
>>> 0xffffbfff
>>>
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> Signed-off-by: Paul Menzel <[email protected]>
>>
>> Reviewed-by: Christian König <[email protected]> for this one.
>>
>> Feel free to add my Acked-by to the other two, but I'm not familiar
>> enough with the code to review those.
>
> Thank you. Sorry for being ignorant, but what is the way forward?
Well, that's a very valid question. The general approach is that driver
changes are pushed upstream through the driver maintainers tree.
Since this driver change depends on a change in the general kernel an rb
from somebody who feels responsible for the code in the general kernel
might be a good idea.
But since you already addressed Linus comments and it looks rather clean
I think I can just push it to drm-misc-next on Monday if nobody objects
over the weekend.
Thanks for the help,
Christian.
>
>
> Kind regards,
>
> Paul
On Fri, Jul 24, 2020 at 12:54 AM Christian König
<[email protected]> wrote:
>
> But since you already addressed Linus comments and it looks rather clean
> I think I can just push it to drm-misc-next on Monday if nobody objects
> over the weekend.
Yeah, no objections from me.
Add a note to it to the pull request, so that when my bird-brain sees
the pull during the next merge window and I've forgotten this thread,
I don't go "why is the drm tree modifying code files"?
Linus
Am 24.07.20 um 22:29 schrieb Linus Torvalds:
> On Fri, Jul 24, 2020 at 12:54 AM Christian König
> <[email protected]> wrote:
>> But since you already addressed Linus comments and it looks rather clean
>> I think I can just push it to drm-misc-next on Monday if nobody objects
>> over the weekend.
> Yeah, no objections from me.
>
> Add a note to it to the pull request, so that when my bird-brain sees
> the pull during the next merge window and I've forgotten this thread,
> I don't go "why is the drm tree modifying code files"?
Well Dave is sending those requests to you usually.
I will just add an Acked-by: Linus Torvalds
<[email protected]> to the patch before pushing :)
Thanks,
Christian.
>
> Linus
> _______________________________________________
> amd-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx