2017-06-21 07:50:51

by Sean Wang

Subject: [PATCH 0/2] fixed ethernet binding violation for reset signal

From: Sean Wang <[email protected]>

Fixed binding violation and also updated related binding documentation to
reflect the reset signals the MediaTek Ethernet requires.

Sean Wang (2):
dt-bindings: net: mediatek: update documentation for reset signals
arm: dts: mt7623: fixup binding violation missing reset in ethernet
node

Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++--
arch/arm/boot/dts/mt7623.dtsi | 4 ++++
2 files changed, 8 insertions(+), 2 deletions(-)

--
2.7.4

2017-06-21 07:51:05

by Sean Wang

Subject: [PATCH 2/2] arm: dts: mt7623: fixup binding violation missing reset in ethernet node

From: Sean Wang <[email protected]>

fix up binding violation where the reset property is required
additionally.

Cc: John Crispin <[email protected]>
Signed-off-by: Sean Wang <[email protected]>
---
arch/arm/boot/dts/mt7623.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index 2202c40..2eca877 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -782,6 +782,10 @@
<&ethsys CLK_ETHSYS_GP2>,
<&apmixedsys CLK_APMIXED_TRGPLL>;
clock-names = "ethif", "esw", "gp1", "gp2", "trgpll";
+ resets = <&ethsys MT2701_ETHSYS_FE_RST>,
+ <&ethsys MT2701_ETHSYS_GMAC_RST>,
+ <&ethsys MT2701_ETHSYS_PPE_RST>;
+ reset-names = "fe", "gmac", "ppe";
power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
mediatek,ethsys = <&ethsys>;
mediatek,pctl = <&syscfg_pctl_a>;
--
2.7.4

2017-06-21 07:50:57

by Sean Wang

Subject: [PATCH 1/2] dt-bindings: net: mediatek: update documentation for reset signals

From: Sean Wang <[email protected]>

Since there's no user for the property reset inside the ethernet node
for current supported MediaTek SoCs and boards, so it should be safe to
update reset property in the bindings to introduce more reset signals as
corresponding that commit 7c2adaf11036 ("reset: mediatek: Add MT2701 ethsys
reset controller include file") did in order to be referenced them from
within a devicetree file.

Cc: John Crispin <[email protected]>
Signed-off-by: Sean Wang <[email protected]>
---
Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
index c7194e8..4eea17e 100644
--- a/Documentation/devicetree/bindings/net/mediatek-net.txt
+++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
@@ -15,8 +15,10 @@ Required properties:
- clock-names: the names of the clock listed in the clocks property. These are
"ethif", "esw", "gp2", "gp1"
- power-domains: phandle to the power domain that the ethernet is part of
-- resets: Should contain a phandle to the ethsys reset signal
-- reset-names: Should contain the reset signal name "eth"
+- resets: Should contain phandles to the ethsys reset signals
+- reset-names: Should contain the names of reset signal listed in the resets
+ property
+ These are "fe", "gmac" and "ppe"
- mediatek,ethsys: phandle to the syscon node that handles the port setup
- mediatek,pctl: phandle to the syscon node that handles the ports slew rate
and driver current
--
2.7.4

2017-06-26 14:52:44

by Rob Herring (Arm)

Subject: Re: [PATCH 1/2] dt-bindings: net: mediatek: update documentation for reset signals

On Wed, Jun 21, 2017 at 03:49:51PM +0800, [email protected] wrote:
> From: Sean Wang <[email protected]>
>
> Since there's no user for the property reset inside the ethernet node
> for current supported MediaTek SoCs and boards, so it should be safe to
> update reset property in the bindings to introduce more reset signals as
> corresponding that commit 7c2adaf11036 ("reset: mediatek: Add MT2701 ethsys
> reset controller include file") did in order to be referenced them from
> within a devicetree file.
>
> Cc: John Crispin <[email protected]>
> Signed-off-by: Sean Wang <[email protected]>
> ---
> Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

Acked-by: Rob Herring <[email protected]>

2017-07-20 03:08:00

by Sean Wang

Subject: Re: [PATCH 0/2] fixed ethernet binding violation for reset signal

Hi, Matthias

just a gentle ping on this

Sean


On Wed, 2017-06-21 at 15:49 +0800, [email protected] wrote:
> From: Sean Wang <[email protected]>
>
> Fixed binding violation and also updated related binding documentation to
> reflect the reset signals the MediaTek Ethernet requires.
>
> Sean Wang (2):
> dt-bindings: net: mediatek: update documentation for reset signals
> arm: dts: mt7623: fixup binding violation missing reset in ethernet
> node
>
> Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++--
> arch/arm/boot/dts/mt7623.dtsi | 4 ++++
> 2 files changed, 8 insertions(+), 2 deletions(-)
>

2017-07-20 11:01:29

by Matthias Brugger

Subject: Re: [PATCH 0/2] fixed ethernet binding violation for reset signal

On 07/20/2017 05:07 AM, Sean Wang wrote:
> Hi, Matthias
>
> just a gentle ping on this
>

Pushed now to v4.13-next/dts32

Thanks!

> Sean
>
>
> On Wed, 2017-06-21 at 15:49 +0800, [email protected] wrote:
>> From: Sean Wang <[email protected]>
>>
>> Fixed binding violation and also updated related binding documentation to
>> reflect the reset signals the MediaTek Ethernet requires.
>>
>> Sean Wang (2):
>> dt-bindings: net: mediatek: update documentation for reset signals
>> arm: dts: mt7623: fixup binding violation missing reset in ethernet
>> node
>>
>> Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++--
>> arch/arm/boot/dts/mt7623.dtsi | 4 ++++
>> 2 files changed, 8 insertions(+), 2 deletions(-)
>>
>
>