2017-08-22 14:06:48

by Bhumika Goyal

Subject: [PATCH] clk: versatile: make clk_ops const

Make this const as it is only stored in the const field of a
clk_init_data structure.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c
index 7e5add7..e7a868b 100644
--- a/drivers/clk/versatile/clk-vexpress-osc.c
+++ b/drivers/clk/versatile/clk-vexpress-osc.c
@@ -61,7 +61,7 @@ static int vexpress_osc_set_rate(struct clk_hw *hw, unsigned long rate,
return regmap_write(osc->reg, 0, rate);
}

-static struct clk_ops vexpress_osc_ops = {
+static const struct clk_ops vexpress_osc_ops = {
.recalc_rate = vexpress_osc_recalc_rate,
.round_rate = vexpress_osc_round_rate,
.set_rate = vexpress_osc_set_rate,
--
1.9.1

2017-08-24 09:54:20

by Liviu Dudau

Subject: Re: [PATCH] clk: versatile: make clk_ops const

On Tue, Aug 22, 2017 at 07:36:26PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the const field of a
> clk_init_data structure.
>
> Signed-off-by: Bhumika Goyal <[email protected]>

Acked-by: Liviu Dudau <[email protected]>

Thanks for the patch!

Sudeep, can you going to pick this up for 4.14?

Best regards,
Liviu

> ---
> drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c
> index 7e5add7..e7a868b 100644
> --- a/drivers/clk/versatile/clk-vexpress-osc.c
> +++ b/drivers/clk/versatile/clk-vexpress-osc.c
> @@ -61,7 +61,7 @@ static int vexpress_osc_set_rate(struct clk_hw *hw, unsigned long rate,
> return regmap_write(osc->reg, 0, rate);
> }
>
> -static struct clk_ops vexpress_osc_ops = {
> +static const struct clk_ops vexpress_osc_ops = {
> .recalc_rate = vexpress_osc_recalc_rate,
> .round_rate = vexpress_osc_round_rate,
> .set_rate = vexpress_osc_set_rate,
> --
> 1.9.1
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯

2017-08-24 10:20:21

by Sudeep Holla

Subject: Re: [PATCH] clk: versatile: make clk_ops const

On 24/08/17 10:54, Liviu Dudau wrote:
> On Tue, Aug 22, 2017 at 07:36:26PM +0530, Bhumika Goyal wrote:
>> Make this const as it is only stored in the const field of a
>> clk_init_data structure.
>>
>> Signed-off-by: Bhumika Goyal <[email protected]>
>
> Acked-by: Liviu Dudau <[email protected]>
>
> Thanks for the patch!
>
> Sudeep, can you going to pick this up for 4.14?
>

IIUC anything under drivers/clk is routed via clk tree.
I assume Mike/Stephen will pick this up.

--
Regards,
Sudeep

2017-08-31 05:39:12

by Stephen Boyd

Subject: Re: [PATCH] clk: versatile: make clk_ops const

On 08/22, Bhumika Goyal wrote:
> Make this const as it is only stored in the const field of a
> clk_init_data structure.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---

Applied to clk-next

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project