2017-08-04 08:10:53

by Guochun Mao

[permalink] [raw]
Subject: [PATCH v5] dt-bindings: mtd: add new compatible strings and improve description

Correct compatibles description and explicate fallback compatible.

Guochun Mao (1):
dt-bindings: mtd: add new compatible strings and improve description

Documentation/devicetree/bindings/mtd/mtk-quadspi.txt | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)

--
1.9.1


2017-08-04 08:10:58

by Guochun Mao

[permalink] [raw]
Subject: [PATCH v5 1/1] dt-bindings: mtd: add new compatible strings and improve description

Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
for nor flash node's compatible strings.
Explicate the fallback compatible.

Signed-off-by: Guochun Mao <[email protected]>
---
.../devicetree/bindings/mtd/mtk-quadspi.txt | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
index 5ded66a..f97d601 100644
--- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
@@ -1,13 +1,16 @@
* Serial NOR flash controller for MTK MT81xx (and similar)

Required properties:
-- compatible: The possible values are:
- "mediatek,mt2701-nor"
- "mediatek,mt7623-nor"
+- compatible: For mt8173, compatible should be "mediatek,mt8173-nor",
+ and it's the fallback compatible for other Soc.
+ For every other SoC, should contain both the SoC-specific compatible
+ string and "mediatek,mt8173-nor".
+ The possible values are:
+ "mediatek,mt2701-nor", "mediatek,mt8173-nor"
+ "mediatek,mt2712-nor", "mediatek,mt8173-nor"
+ "mediatek,mt7622-nor", "mediatek,mt8173-nor"
+ "mediatek,mt7623-nor", "mediatek,mt8173-nor"
"mediatek,mt8173-nor"
- For mt8173, compatible should be "mediatek,mt8173-nor".
- For every other SoC, should contain both the SoC-specific compatible string
- and "mediatek,mt8173-nor".
- reg: physical base address and length of the controller's register
- clocks: the phandle of the clocks needed by the nor controller
- clock-names: the names of the clocks
--
1.7.9.5

2017-08-10 18:21:57

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v5 1/1] dt-bindings: mtd: add new compatible strings and improve description

On Fri, Aug 04, 2017 at 04:10:39PM +0800, Guochun Mao wrote:
> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> for nor flash node's compatible strings.
> Explicate the fallback compatible.
>
> Signed-off-by: Guochun Mao <[email protected]>
> ---
> .../devicetree/bindings/mtd/mtk-quadspi.txt | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)

Acked-by: Rob Herring <[email protected]>

2017-08-17 01:51:43

by Guochun Mao

[permalink] [raw]
Subject: Re: [PATCH v5 1/1] dt-bindings: mtd: add new compatible strings and improve description

On Thu, 2017-08-10 at 13:21 -0500, Rob Herring wrote:
> On Fri, Aug 04, 2017 at 04:10:39PM +0800, Guochun Mao wrote:
> > Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > for nor flash node's compatible strings.
> > Explicate the fallback compatible.
> >
> > Signed-off-by: Guochun Mao <[email protected]>
> > ---
> > .../devicetree/bindings/mtd/mtk-quadspi.txt | 15 +++++++++------
> > 1 file changed, 9 insertions(+), 6 deletions(-)
>
> Acked-by: Rob Herring <[email protected]>

Hi Rob,
Thank you very much!

Hi Matthias, Cyrille,
Thanks a lot for your efforts in reviewing the patch.

Is there any comment about the patch this version?
I appreciate your suggestion.

BR,
Guochun

2017-08-28 08:48:07

by Guochun Mao

[permalink] [raw]
Subject: Re: [PATCH v5 1/1] dt-bindings: mtd: add new compatible strings and improve description

Hi Cyrille,

It seems that I sent mail to wrong email-address ;)
Please help to review this patch.

Thanks a lot.

Guochun

On Thu, 2017-08-17 at 09:51 +0800, Guochun Mao wrote:
> On Thu, 2017-08-10 at 13:21 -0500, Rob Herring wrote:
> > On Fri, Aug 04, 2017 at 04:10:39PM +0800, Guochun Mao wrote:
> > > Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
> > > for nor flash node's compatible strings.
> > > Explicate the fallback compatible.
> > >
> > > Signed-off-by: Guochun Mao <[email protected]>
> > > ---
> > > .../devicetree/bindings/mtd/mtk-quadspi.txt | 15 +++++++++------
> > > 1 file changed, 9 insertions(+), 6 deletions(-)
> >
> > Acked-by: Rob Herring <[email protected]>
>
> Hi Rob,
> Thank you very much!
>
> Hi Matthias, Cyrille,
> Thanks a lot for your efforts in reviewing the patch.
>
> Is there any comment about the patch this version?
> I appreciate your suggestion.
>
> BR,
> Guochun