2017-11-18 00:29:40

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 01/10] Input: ep93xx_keypad: Fix platform_get_irq's error checking

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/input/keyboard/ep93xx_keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
index f77b295..67efdc9 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -257,7 +257,7 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
}

keypad->irq = platform_get_irq(pdev, 0);
- if (!keypad->irq) {
+ if (keypad->irq < 0) {
err = -ENXIO;
goto failed_free;
}
--
2.7.4


From 1584600737574421071@xxx Mon Nov 20 15:50:25 +0000 2017
X-GM-THRID: 1584356489495704941
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread