2017-11-18 02:33:10

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 03/10] Input: twl4030_keypad: Fix platform_get_irq's error checking

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/input/keyboard/twl4030_keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/twl4030_keypad.c b/drivers/input/keyboard/twl4030_keypad.c
index f9f98ef..f94090e 100644
--- a/drivers/input/keyboard/twl4030_keypad.c
+++ b/drivers/input/keyboard/twl4030_keypad.c
@@ -389,7 +389,7 @@ static int twl4030_kp_probe(struct platform_device *pdev)
}

kp->irq = platform_get_irq(pdev, 0);
- if (!kp->irq) {
+ if (kp->irq < 0) {
dev_err(&pdev->dev, "no keyboard irq assigned\n");
return -EINVAL;
}
--
2.7.4


From 1584377795936156236@xxx Sat Nov 18 04:46:51 +0000 2017
X-GM-THRID: 1584377795936156236
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread